Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2695393002: Revise the comment on base::IDMap::Replace() (Closed)

Created:
3 years, 10 months ago by Sungmann Cho
Modified:
3 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revise the comment on base::IDMap::Replace() IDMapOwnPointer mode was removed at https://codereview.chromium.org/2496653002, but that mode is still mentioned in the comment on base::IDMap::Replace(). That should be removed. BUG=647091 Review-Url: https://codereview.chromium.org/2695393002 Cr-Commit-Position: refs/heads/master@{#451216} Committed: https://chromium.googlesource.com/chromium/src/+/82e601f9fcd894f16fb9e4df96f71d7fc5af83f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/id_map.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sungmann Cho
Please take a look. Thanks!
3 years, 10 months ago (2017-02-16 01:17:19 UTC) #3
danakj
> TEST=Compile The TEST line is meant for QA people to verify a fix. There ...
3 years, 10 months ago (2017-02-16 15:58:22 UTC) #4
Sungmann Cho
On 2017/02/16 15:58:22, danakj wrote: > > TEST=Compile > > The TEST line is meant ...
3 years, 10 months ago (2017-02-17 00:40:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695393002/1
3 years, 10 months ago (2017-02-17 00:42:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on ...
3 years, 10 months ago (2017-02-17 02:46:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695393002/1
3 years, 10 months ago (2017-02-17 04:08:17 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 04:44:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82e601f9fcd894f16fb9e4df96f7...

Powered by Google App Engine
This is Rietveld 408576698