Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: base/id_map.h

Issue 2695393002: Revise the comment on base::IDMap::Replace() (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/id_map.h
diff --git a/base/id_map.h b/base/id_map.h
index 8545de84084fc7c116132051754d4222f130c3e8..d171fb14c102cefc5b5ec332315e8a7303f86b9c 100644
--- a/base/id_map.h
+++ b/base/id_map.h
@@ -81,9 +81,8 @@ class IDMap final {
}
}
- // Replaces the value for |id| with |new_data| and returns the existing value
- // (as a unique_ptr<> if in IDMapOwnPointer mode). Should only be called with
- // an already added id.
+ // Replaces the value for |id| with |new_data| and returns the existing value.
+ // Should only be called with an already added id.
V Replace(KeyType id, V new_data) {
DCHECK(sequence_checker_.CalledOnValidSequence());
DCHECK(!check_on_null_data_ || new_data);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698