Mojo C++ bindings: remove usage of AssociatedGroup from content/

Mojo C++ bindings: remove usage of AssociatedGroup from content/

This class is now supposed to be used in bindings-internal code. Users don't have to know about it.

BUG=682334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2695333002
Cr-Commit-Position: refs/heads/master@{#451104}
Committed: https://chromium.googlesource.com/chromium/src/+/20d07510536b4baf185e7e9ccfac66fe5dae9415

[yzshen1, 2017-02-15 20:50:24]

Description was changed from

==========
Mojo C++ bindings: remove usage of AssociatedGroup from content/

This class is now supposed to be used in bindings-internal code. Users don't
have to know about it.

BUG=682334
==========

to

==========
Mojo C++ bindings: remove usage of AssociatedGroup from content/

This class is now supposed to be used in bindings-internal code. Users don't
have to know about it.

BUG=682334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[yzshen1, 2017-02-15 20:51:59]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 20:53:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 21:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:19:25]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[yzshen1, 2017-02-15 21:20:31]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 21:21:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-02-15 21:40:36]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 21:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-02-15 22:14:59]

yzshen@chromium.org changed reviewers:
+ jam@chromium.org

[yzshen1, 2017-02-15 22:15:00]

Hi, John.

Would you please take a look?

This is a fairly mechanical cleanup. The AssociatedGroup parameter passed into
mojo bindings calls such as mojo::MakeRequest() / Binding::Bind() has already
been ignored. This CL changes the callsites to get rid of this redundant
argument.

Thanks!

[commit-bot: I haz the power, 2017-02-16 00:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:10:28]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2017-02-16 01:07:47]

lgtm

[yzshen1, 2017-02-16 01:08:06]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:09:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:12:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[yzshen1, 2017-02-16 04:10:30]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:35:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[yzshen1, 2017-02-16 16:44:21]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-02-16 16:45:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 16:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 16:52:10]

Failed to apply patch for content/browser/leveldb_wrapper_impl_unittest.cc:
While running git apply --index -p1;
  error: patch failed: content/browser/leveldb_wrapper_impl_unittest.cc:133
  error: content/browser/leveldb_wrapper_impl_unittest.cc: patch does not apply

Patch:       content/browser/leveldb_wrapper_impl_unittest.cc
Index: content/browser/leveldb_wrapper_impl_unittest.cc
diff --git a/content/browser/leveldb_wrapper_impl_unittest.cc
b/content/browser/leveldb_wrapper_impl_unittest.cc
index
a753a94b74b13d2fcb16f5ae2836050425f6869e..313b76284cf789ca99bfeb4abcb0f67457354dbf
100644
--- a/content/browser/leveldb_wrapper_impl_unittest.cc
+++ b/content/browser/leveldb_wrapper_impl_unittest.cc
@@ -27,13 +27,10 @@ const size_t kTestSizeLimit = 512;
 class GetAllCallback : public mojom::LevelDBWrapperGetAllCallback {
  public:
   static mojom::LevelDBWrapperGetAllCallbackAssociatedPtrInfo CreateAndBind(
-      mojo::AssociatedGroup* associated_group,
       bool* result,
       const base::Closure& callback) {
     mojom::LevelDBWrapperGetAllCallbackAssociatedPtrInfo ptr_info;
-    mojom::LevelDBWrapperGetAllCallbackAssociatedRequest request;
-    associated_group->CreateAssociatedInterface(
-        mojo::AssociatedGroup::WILL_PASS_PTR, &ptr_info, &request);
+    auto request = mojo::MakeRequest(&ptr_info);
     mojo::MakeStrongAssociatedBinding(
         base::WrapUnique(new GetAllCallback(result, callback)),
         std::move(request));
@@ -109,7 +106,7 @@ class LevelDBWrapperImplTest : public testing::Test,
 
     level_db_wrapper_.Bind(mojo::MakeRequest(&level_db_wrapper_ptr_));
     mojom::LevelDBObserverAssociatedPtrInfo ptr_info;
-    observer_binding_.Bind(&ptr_info, associated_group());
+    observer_binding_.Bind(&ptr_info);
     level_db_wrapper_ptr_->AddObserver(std::move(ptr_info));
   }
 
@@ -133,9 +130,6 @@ class LevelDBWrapperImplTest : public testing::Test,
   }
 
   mojom::LevelDBWrapper* wrapper() { return level_db_wrapper_ptr_.get(); }
-  mojo::AssociatedGroup* associated_group() {
-    return level_db_wrapper_ptr_.associated_group();
-  }
 
   bool GetSync(const std::vector<uint8_t>& key, std::vector<uint8_t>* result) {
     base::RunLoop run_loop;
@@ -254,9 +248,8 @@ TEST_F(LevelDBWrapperImplTest, GetAll) {
   base::RunLoop run_loop;
   bool result = false;
   EXPECT_TRUE(wrapper()->GetAll(
-      GetAllCallback::CreateAndBind(associated_group(), &result,
-                                    run_loop.QuitClosure()),
-      &status, &data));
+      GetAllCallback::CreateAndBind(&result, run_loop.QuitClosure()), &status,
+      &data));
   EXPECT_EQ(leveldb::mojom::DatabaseError::OK, status);
   EXPECT_EQ(2u, data.size());
   EXPECT_FALSE(result);

[yzshen1, 2017-02-16 17:35:09]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-02-16 17:35:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2695333002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-02-16 17:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 18:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:37:55]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2017-02-16 21:04:04]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:05:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 21:36:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487279044008530,
"parent_rev": "f983e4df6875c3d0028474ee6b828ae01f359376", "commit_rev":
"20d07510536b4baf185e7e9ccfac66fe5dae9415"}

[commit-bot: I haz the power, 2017-02-16 21:37:50]

Description was changed from

==========
Mojo C++ bindings: remove usage of AssociatedGroup from content/

This class is now supposed to be used in bindings-internal code. Users don't
have to know about it.

BUG=682334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Mojo C++ bindings: remove usage of AssociatedGroup from content/

This class is now supposed to be used in bindings-internal code. Users don't
have to know about it.

BUG=682334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2695333002
Cr-Commit-Position: refs/heads/master@{#451104}
Committed:
https://chromium.googlesource.com/chromium/src/+/20d07510536b4baf185e7e9ccfac...
==========

[commit-bot: I haz the power, 2017-02-16 21:37:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/20d07510536b4baf185e7e9ccfac...