Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 2695333002: Mojo C++ bindings: remove usage of AssociatedGroup from content/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by yzshen1
Modified:
1 week, 1 day ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, darin-cc_chromium.org, loading-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Randy Smith (Not in Mondays), nhiroki, jsbell+idb_chromium.org, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, cmumford, horo+watch_chromium.org, darin (slow to review), mmenke (Out Feb 4 to March 5)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove usage of AssociatedGroup from content/ This class is now supposed to be used in bindings-internal code. Users don't have to know about it. BUG=682334 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2695333002 Cr-Commit-Position: refs/heads/master@{#451104} Committed: https://chromium.googlesource.com/chromium/src/+/20d07510536b4baf185e7e9ccfac66fe5dae9415

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -188 lines) Patch
M content/browser/dom_storage/local_storage_context_mojo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M content/browser/leveldb_wrapper_impl_unittest.cc View 1 2 3 4 chunks +4 lines, -11 lines 0 comments Download
M content/browser/loader/downloaded_temp_file_impl.h View 2 chunks +4 lines, -9 lines 0 comments Download
M content/browser/loader/downloaded_temp_file_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/loader/test_url_loader_client.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/loader/test_url_loader_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 1 2 3 9 chunks +23 lines, -32 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/child/resource_dispatcher.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/child/resource_dispatcher.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/url_loader_client_impl.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/child/url_loader_client_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/child/url_loader_client_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 6 chunks +6 lines, -15 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/associated_interface_provider_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/associated_interface_provider_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/associated_interface_provider.h View 2 chunks +1 line, -10 lines 0 comments Download
M content/renderer/dom_storage/local_storage_cached_area.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 36 (24 generated)
yzshen1
Hi, John. Would you please take a look? This is a fairly mechanical cleanup. The ...
1 week, 2 days ago (2017-02-15 22:15:00 UTC) #11
jam
lgtm
1 week, 2 days ago (2017-02-16 01:07:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695333002/40001
1 week, 2 days ago (2017-02-16 01:09:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_site_isolation on ...
1 week, 1 day ago (2017-02-16 03:12:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695333002/40001
1 week, 1 day ago (2017-02-16 04:11:23 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
1 week, 1 day ago (2017-02-16 05:35:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695333002/40001
1 week, 1 day ago (2017-02-16 16:45:03 UTC) #24
commit-bot: I haz the power
Failed to apply patch for content/browser/leveldb_wrapper_impl_unittest.cc: While running git apply --index -p1; error: patch failed: ...
1 week, 1 day ago (2017-02-16 16:52:10 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695333002/60001
1 week, 1 day ago (2017-02-16 17:35:44 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/312556)
1 week, 1 day ago (2017-02-16 18:37:55 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695333002/60001
1 week, 1 day ago (2017-02-16 21:05:17 UTC) #33
commit-bot: I haz the power
1 week, 1 day ago (2017-02-16 21:37:52 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/20d07510536b4baf185e7e9ccfac...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd