Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2695303003: [Merge M57] Display a simple tooltip text for empty labels in verbose states (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] Display a simple tooltip text for empty labels in verbose states As of M57, verbose state bubbles are used to display extension names. When the process for an extension crashes or is killed, the bubble label will be empty. This leads to a leading dot to be displayed in the bubble tooltip. This CL fixes that. BUG=691922 TBR=rsesek@chromium.org Review-Url: https://codereview.chromium.org/2697903002 Cr-Commit-Position: refs/heads/master@{#450484} (cherry picked from commit 1a2fcc1a4c4a40629e10b1a067004ace091ef341) Review-Url: https://codereview.chromium.org/2695303003 . Cr-Commit-Position: refs/branch-heads/2987@{#532} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1174093e0197a1ec4cb655d8ec599c6b2c0ceae7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
meacer
3 years, 10 months ago (2017-02-15 22:26:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1174093e0197a1ec4cb655d8ec599c6b2c0ceae7.

Powered by Google App Engine
This is Rietveld 408576698