Display a simple tooltip text for empty labels in verbose states

Display a simple tooltip text for empty labels in verbose states

As of M57, verbose state bubbles are used to display extension names.
When the process for an extension crashes or is killed, the bubble label will
be empty. This leads to a leading dot to be displayed in the bubble tooltip.
This CL fixes that.

BUG=691922
Review-Url: https://codereview.chromium.org/2697903002
Cr-Commit-Position: refs/heads/master@{#450484}
Committed: https://chromium.googlesource.com/chromium/src/+/1a2fcc1a4c4a40629e10b1a067004ace091ef341

[meacer, 2017-02-14 20:23:37]

meacer@chromium.org changed reviewers:
+ rsesek@chromium.org

[meacer, 2017-02-14 20:23:37]

rsesek: PTAL?

[meacer, 2017-02-14 20:24:25]

Description was changed from

==========
Display a simple tooltip text verbose states if the label string is empty

As of M57, verbose state bubbles are used to display extension names.
When the process for an extension crashes or is killed, the bubble label will
be empty. This leads to a leading dot to be displayed in the bubble tooltip.
This CL fixes that.

BUG=691922
==========

to

==========
Display a simple tooltip text for empty labels in verbose states

As of M57, verbose state bubbles are used to display extension names.
When the process for an extension crashes or is killed, the bubble label will
be empty. This leads to a leading dot to be displayed in the bubble tooltip.
This CL fixes that.

BUG=691922
==========

[Robert Sesek, 2017-02-14 21:11:26]

https://codereview.chromium.org/2697903002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
(right):

https://codereview.chromium.org/2697903002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:282: if
([full_label_.get() length] == 0)
You should be able to drop the .get() here.

https://codereview.chromium.org/2697903002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:283:
return l10n_util::GetNSStringWithFixup(IDS_TOOLTIP_LOCATION_ICON);
Pull this out into a local and use it on line 285, too?

[meacer, 2017-02-14 21:22:10]

https://codereview.chromium.org/2697903002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
(right):

https://codereview.chromium.org/2697903002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:282: if
([full_label_.get() length] == 0)
On 2017/02/14 21:11:25, Robert Sesek wrote:
> You should be able to drop the .get() here.

Done.

https://codereview.chromium.org/2697903002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:283:
return l10n_util::GetNSStringWithFixup(IDS_TOOLTIP_LOCATION_ICON);
On 2017/02/14 21:11:25, Robert Sesek wrote:
> Pull this out into a local and use it on line 285, too?

Done.

[Robert Sesek, 2017-02-14 21:22:38]

lgtm

[meacer, 2017-02-14 21:24:25]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:25:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:00:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487107465568320,
"parent_rev": "618b40d65c8372e95c3fb7bf848560b2a9b14a34", "commit_rev":
"1a2fcc1a4c4a40629e10b1a067004ace091ef341"}

[commit-bot: I haz the power, 2017-02-14 22:01:03]

Description was changed from

==========
Display a simple tooltip text for empty labels in verbose states

As of M57, verbose state bubbles are used to display extension names.
When the process for an extension crashes or is killed, the bubble label will
be empty. This leads to a leading dot to be displayed in the bubble tooltip.
This CL fixes that.

BUG=691922
==========

to

==========
Display a simple tooltip text for empty labels in verbose states

As of M57, verbose state bubbles are used to display extension names.
When the process for an extension crashes or is killed, the bubble label will
be empty. This leads to a leading dot to be displayed in the bubble tooltip.
This CL fixes that.

BUG=691922

Review-Url: https://codereview.chromium.org/2697903002
Cr-Commit-Position: refs/heads/master@{#450484}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a2fcc1a4c4a40629e10b1a06700...
==========

[commit-bot: I haz the power, 2017-02-14 22:01:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a2fcc1a4c4a40629e10b1a06700...