Convert MediaElementAudioSource tests to testharness.

Convert MediaElementAudioSource tests to testharness.

These were all converted by hand to use testharness and new Audit.

BUG=692724
TEST=mediaelementaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2695283003
Cr-Commit-Position: refs/heads/master@{#458141}
Committed: https://chromium.googlesource.com/chromium/src/+/973641c0ccf64c6c4c0919ed93cd3cd1f609b2e7

[Raymond Toy, 2017-02-24 17:34:37]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-24 17:34:37]

PTAL

[hongchan, 2017-02-24 23:32:27]

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html
(right):

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html:30:
gc();
It will cause 'undefined' if this test runs on the browser. Is that okay?

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html
(right):

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html:13:
let source;
Does this have to be global?

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html:21:
gc();
We need some gate logic when this test runs on the browser. Or simply we can
leave a comment at the top that this test only runs on the content shell with
the internal GC method.

[Raymond Toy, 2017-02-24 23:36:59]

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html
(right):

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html:30:
gc();
On 2017/02/24 23:32:26, hongchan wrote:
> It will cause 'undefined' if this test runs on the browser. Is that okay?

The original did the same, so I didn't change that. (But in a different test, I
at least wrapped the call to gc in should().notThrow().  Is that better?

[hongchan, 2017-02-24 23:45:21]

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html
(right):

https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html:30:
gc();
On 2017/02/24 23:36:58, Raymond Toy wrote:
> On 2017/02/24 23:32:26, hongchan wrote:
> > It will cause 'undefined' if this test runs on the browser. Is that okay?
> 
> The original did the same, so I didn't change that. (But in a different test,
I
> at least wrapped the call to gc in should().notThrow().  Is that better?

Clarifying somehow the test is not designed for the browser would be good. We
can do something fancy, or just leave a comment at the top.

[Raymond Toy, 2017-03-09 17:43:06]

In an offline discussion, we decided to update just
mediaelementaudiosourcenode.html.  The other tests call gc() so it's not very
portable to wpt.

[Raymond Toy, 2017-03-09 18:11:44]

Description was changed from

==========
Convert MediaElementAudioSource tests to testharness.

These were all converted by hand to use testharness and new Audit.

BUG=692724
TEST=mediaelementaudiosourcenode-gc.html,
mediaelementaudiosourcenode-wrapper.html,
mediaelementaudiosourcenode.html
==========

to

==========
Convert MediaElementAudioSource tests to testharness.

These were all converted by hand to use testharness and new Audit.

BUG=692724
TEST=mediaelementaudiosourcenode.html
==========

[hongchan, 2017-03-16 21:45:15]

On 2017/03/09 17:43:06, Raymond Toy wrote:
> In an offline discussion, we decided to update just
> mediaelementaudiosourcenode.html.  The other tests call gc() so it's not very
> portable to wpt.

Can we close this then?

[Raymond Toy, 2017-03-16 22:27:41]

On 2017/03/16 21:45:15, hongchan wrote:
> On 2017/03/09 17:43:06, Raymond Toy wrote:
> > In an offline discussion, we decided to update just
> > mediaelementaudiosourcenode.html.  The other tests call gc() so it's not
very
> > portable to wpt.
> 
> Can we close this then?

Why? #5 says we wanted to update mediaelementaudiosourcenode.html.  Are you now
saying we don't want any of this?

[hongchan, 2017-03-20 17:50:09]

lgtm

[Raymond Toy, 2017-03-20 17:52:09]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-20 17:52:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490032329452320,
"parent_rev": "8fe439b946c4f1f5e4a15cd5d8be32cfb9e279a0", "commit_rev":
"973641c0ccf64c6c4c0919ed93cd3cd1f609b2e7"}

[commit-bot: I haz the power, 2017-03-20 19:05:56]

Description was changed from

==========
Convert MediaElementAudioSource tests to testharness.

These were all converted by hand to use testharness and new Audit.

BUG=692724
TEST=mediaelementaudiosourcenode.html
==========

to

==========
Convert MediaElementAudioSource tests to testharness.

These were all converted by hand to use testharness and new Audit.

BUG=692724
TEST=mediaelementaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2695283003
Cr-Commit-Position: refs/heads/master@{#458141}
Committed:
https://chromium.googlesource.com/chromium/src/+/973641c0ccf64c6c4c0919ed93cd...
==========

[commit-bot: I haz the power, 2017-03-20 19:05:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/973641c0ccf64c6c4c0919ed93cd...