Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2695283003: Convert MediaElementAudioSource tests to testharness. (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MediaElementAudioSource tests to testharness. These were all converted by hand to use testharness and new Audit. BUG=692724 TEST=mediaelementaudiosourcenode.html Review-Url: https://codereview.chromium.org/2695283003 Cr-Commit-Position: refs/heads/master@{#458141} Committed: https://chromium.googlesource.com/chromium/src/+/973641c0ccf64c6c4c0919ed93cd3cd1f609b2e7

Patch Set 1 #

Patch Set 2 : Remove task.describe #

Total comments: 5

Patch Set 3 : Revert changes to *-{gc,wrapper}.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html View 1 1 chunk +44 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-24 17:34:37 UTC) #2
hongchan
https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html File third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html (right): https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html#newcode30 third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html:30: gc(); It will cause 'undefined' if this test runs ...
3 years, 10 months ago (2017-02-24 23:32:27 UTC) #3
Raymond Toy
https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html File third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html (right): https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html#newcode30 third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html:30: gc(); On 2017/02/24 23:32:26, hongchan wrote: > It will ...
3 years, 10 months ago (2017-02-24 23:36:59 UTC) #4
hongchan
https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html File third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html (right): https://codereview.chromium.org/2695283003/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html#newcode30 third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-gc.html:30: gc(); On 2017/02/24 23:36:58, Raymond Toy wrote: > On ...
3 years, 10 months ago (2017-02-24 23:45:21 UTC) #5
Raymond Toy
In an offline discussion, we decided to update just mediaelementaudiosourcenode.html. The other tests call gc() ...
3 years, 9 months ago (2017-03-09 17:43:06 UTC) #6
hongchan
On 2017/03/09 17:43:06, Raymond Toy wrote: > In an offline discussion, we decided to update ...
3 years, 9 months ago (2017-03-16 21:45:15 UTC) #8
Raymond Toy
On 2017/03/16 21:45:15, hongchan wrote: > On 2017/03/09 17:43:06, Raymond Toy wrote: > > In ...
3 years, 9 months ago (2017-03-16 22:27:41 UTC) #9
hongchan
lgtm
3 years, 9 months ago (2017-03-20 17:50:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695283003/40001
3 years, 9 months ago (2017-03-20 17:52:31 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 19:05:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/973641c0ccf64c6c4c0919ed93cd...

Powered by Google App Engine
This is Rietveld 408576698