Chromium Code Reviews Chromium Code Reviews
Issue 2695283003:
Convert MediaElementAudioSource tests to testharness. (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <script src="../../resources/js-test.js"></script> | 4 <script src="../../resources/testharness.js"></script> |
| 5 <script src="../../resources/testharnessreport.js"></script> | |
| 5 <script src="../resources/audit-util.js"></script> | 6 <script src="../resources/audit-util.js"></script> |
| 6 <script src="../resources/audio-testing.js"></script> | 7 <script src="../resources/audit.js"></script> |
| 7 </head> | 8 </head> |
| 8 <body> | 9 <body> |
| 9 <script> | 10 <script> |
| 10 description("Verifies that for .mediaElement getters, a wrapper that corresponds to the actual element is created."); | 11 let audit = Audit.createTaskRunner(); |
| 11 | 12 |
| 12 var source; | 13 let source; |
|
hongchan
2017/02/24 23:32:26
Does this have to be global?
| |
| 13 function testMediaWrapper(kind) { | |
| 14 var element = document.createElement(kind); | |
| 15 var context = new AudioContext(); | |
| 16 | 14 |
| 17 source = context.createMediaElementSource(element); | 15 function testMediaWrapper(kind, should) { |
| 18 element = context = null; | 16 let element = document.createElement(kind); |
| 19 gc(); | 17 let context = new AudioContext(); |
| 20 shouldBeUndefined('source.mediaElement.nonExistentProperty'); | 18 |
| 21 source = null; | 19 source = context.createMediaElementSource(element); |
| 20 element = context = null; | |
| 21 gc(); | |
|
hongchan
2017/02/24 23:32:26
We need some gate logic when this test runs on the
| |
| 22 | |
| 23 should( | |
| 24 source.mediaElement.nonExistentProperty === undefined, | |
| 25 'source.mediaElement.nonExistentProperty is undefined') | |
| 26 .beTrue(); | |
| 27 | |
| 28 source = null; | |
| 22 } | 29 } |
| 23 | 30 |
| 24 testMediaWrapper('audio'); | 31 audit.define( |
| 25 testMediaWrapper('video'); | 32 { |
| 33 label: 'audio', | |
| 34 descrition: 'Verifies that audioElement getters are wrapped correctly' | |
| 35 }, | |
| 36 (task, should) => { | |
| 37 testMediaWrapper('audio', should); | |
| 38 task.done(); | |
| 39 }); | |
| 40 | |
| 41 audit.define( | |
| 42 { | |
| 43 label: 'video', | |
| 44 description: 'Verifies that videoElement getters are wrapped correctly' | |
| 45 }, | |
| 46 (task, should) => { | |
| 47 testMediaWrapper('video', should); | |
| 48 task.done(); | |
| 49 }); | |
| 50 | |
| 51 audit.run(); | |
| 26 </script> | 52 </script> |
| 27 </body> | 53 </body> |
| 28 </html> | 54 </html> |
| OLD | NEW |
