CrOS: Add firmware version to about://version

CrOS: Add firmware version to about://version

BUG=686847
TBR=jochen@chromium.org
TBR_REASON=version_ui_strings is missing a per-file owner line

Review-Url: https://codereview.chromium.org/2695123007
Cr-Commit-Position: refs/heads/master@{#451092}
Committed: https://chromium.googlesource.com/chromium/src/+/b4ad43452375d226681b9aab645f8eef3ba48204

[stevenjb, 2017-02-15 23:29:08]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-02-16 04:20:31]

lgtm

https://codereview.chromium.org/2695123007/diff/1/components/version_ui/resou...
File components/version_ui/resources/about_version.js (right):

https://codereview.chromium.org/2695123007/diff/1/components/version_ui/resou...
components/version_ui/resources/about_version.js:44: * Callback from the backend
with the Firmware version to display.
nit: lowercase firmware

[stevenjb, 2017-02-16 18:24:25]

https://codereview.chromium.org/2695123007/diff/1/components/version_ui/resou...
File components/version_ui/resources/about_version.js (right):

https://codereview.chromium.org/2695123007/diff/1/components/version_ui/resou...
components/version_ui/resources/about_version.js:44: * Callback from the backend
with the Firmware version to display.
On 2017/02/16 04:20:31, michaelpg wrote:
> nit: lowercase firmware

Done.

[stevenjb, 2017-02-16 18:24:29]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-16 18:24:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2695123007/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-02-16 18:25:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 18:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:39:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[stevenjb, 2017-02-16 18:42:30]

stevenjb@chromium.org changed reviewers:
+ achuith@chromium.org

[stevenjb, 2017-02-16 18:42:30]

+achuith@ for components/version_ui OWNERS

[achuithb, 2017-02-16 20:08:36]

lgtm

https://codereview.chromium.org/2695123007/diff/20001/components/version_ui/r...
File components/version_ui/resources/about_version.js (right):

https://codereview.chromium.org/2695123007/diff/20001/components/version_ui/r...
components/version_ui/resources/about_version.js:45: * @param {string}
firmwareVersion
the firmware version to display.

[stevenjb, 2017-02-16 20:26:54]

https://codereview.chromium.org/2695123007/diff/20001/components/version_ui/r...
File components/version_ui/resources/about_version.js (right):

https://codereview.chromium.org/2695123007/diff/20001/components/version_ui/r...
components/version_ui/resources/about_version.js:45: * @param {string}
firmwareVersion
On 2017/02/16 20:08:36, achuithb wrote:
> the firmware version to display.

I didn't mess with the other comments, but we've been moving towards more
succinct comments; the return value is already well described by the name and
the function comment.

[stevenjb, 2017-02-16 20:28:24]

Description was changed from

==========
CrOS: Add firmware version to about://version

BUG=686847
==========

to

==========
CrOS: Add firmware version to about://version

BUG=686847
TBR=jochen@chromium.org
TBR_REASON=version_ui_strings is missing a per-file owner line
==========

[stevenjb, 2017-02-16 20:28:29]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:43:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487276909972280,
"parent_rev": "ad2289a98e5eba693086edaff0c5464f61c66b5f", "commit_rev":
"b4ad43452375d226681b9aab645f8eef3ba48204"}

[commit-bot: I haz the power, 2017-02-16 20:43:47]

Description was changed from

==========
CrOS: Add firmware version to about://version

BUG=686847
TBR=jochen@chromium.org
TBR_REASON=version_ui_strings is missing a per-file owner line
==========

to

==========
CrOS: Add firmware version to about://version

BUG=686847
TBR=jochen@chromium.org
TBR_REASON=version_ui_strings is missing a per-file owner line

Review-Url: https://codereview.chromium.org/2695123007
Cr-Commit-Position: refs/heads/master@{#451092}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4ad43452375d226681b9aab645f...
==========

[commit-bot: I haz the power, 2017-02-16 20:43:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4ad43452375d226681b9aab645f...