Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: chrome/browser/ui/webui/version_ui.cc

Issue 2695123007: CrOS: Add firmware version to about://version (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/version_ui.h" 5 #include "chrome/browser/ui/webui/version_ui.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/i18n/message_formatter.h" 8 #include "base/i18n/message_formatter.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 IDS_VERSION_UI_PROFILE_PATH); 86 IDS_VERSION_UI_PROFILE_PATH);
87 html_source->AddString(version_ui::kProfilePath, std::string()); 87 html_source->AddString(version_ui::kProfilePath, std::string());
88 html_source->AddLocalizedString(version_ui::kVariationsName, 88 html_source->AddLocalizedString(version_ui::kVariationsName,
89 IDS_VERSION_UI_VARIATIONS); 89 IDS_VERSION_UI_VARIATIONS);
90 90
91 #if defined(OS_CHROMEOS) 91 #if defined(OS_CHROMEOS)
92 html_source->AddLocalizedString(version_ui::kARC, IDS_ARC_LABEL); 92 html_source->AddLocalizedString(version_ui::kARC, IDS_ARC_LABEL);
93 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL); 93 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL);
94 html_source->AddLocalizedString(version_ui::kCustomizationId, 94 html_source->AddLocalizedString(version_ui::kCustomizationId,
95 IDS_VERSION_UI_CUSTOMIZATION_ID); 95 IDS_VERSION_UI_CUSTOMIZATION_ID);
96 html_source->AddLocalizedString(version_ui::kFirmwareVersion,
97 IDS_VERSION_UI_FIRMWARE_VERSION);
96 #else 98 #else
97 html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS); 99 html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS);
98 html_source->AddString(version_ui::kOSType, version_info::GetOSType()); 100 html_source->AddString(version_ui::kOSType, version_info::GetOSType());
99 #endif // OS_CHROMEOS 101 #endif // OS_CHROMEOS
100 102
101 #if defined(OS_ANDROID) 103 #if defined(OS_ANDROID)
102 html_source->AddString(version_ui::kOSVersion, 104 html_source->AddString(version_ui::kOSVersion,
103 AndroidAboutAppInfo::GetOsInfo()); 105 AndroidAboutAppInfo::GetOsInfo());
104 #else 106 #else
105 html_source->AddString(version_ui::kFlashPlugin, "Flash"); 107 html_source->AddString(version_ui::kFlashPlugin, "Flash");
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 // Set up the chrome://theme/ source. 179 // Set up the chrome://theme/ source.
178 ThemeSource* theme = new ThemeSource(profile); 180 ThemeSource* theme = new ThemeSource(profile);
179 content::URLDataSource::Add(profile, theme); 181 content::URLDataSource::Add(profile, theme);
180 #endif 182 #endif
181 183
182 WebUIDataSource::Add(profile, CreateVersionUIDataSource()); 184 WebUIDataSource::Add(profile, CreateVersionUIDataSource());
183 } 185 }
184 186
185 VersionUI::~VersionUI() { 187 VersionUI::~VersionUI() {
186 } 188 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698