content/browser/frame_host/render_widget_host_view_child_frame.h - Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.h

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.h b/content/browser/frame_host/render_widget_host_view_child_frame.h

index 3086266975fe8d0984fc7028af1de488fdd59076..681eeb40b0f6ad50d213d1f1288e8d434d178413 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.h

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.h

@@ -74,7 +74,6 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame

void InitAsChild(gfx::NativeView parent_view) override;

RenderWidgetHost* GetRenderWidgetHost() const override;

void SetSize(const gfx::Size& size) override;

- void SetBounds(const gfx::Rect& rect) override;

void Focus() override;

bool HasFocus() const override;

bool IsSurfaceAvailableForCopy() const override;

@@ -95,6 +94,7 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame

void InitAsPopup(RenderWidgetHostView* parent_host_view,

const gfx::Rect& bounds) override;

void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;

+ void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

void RenderProcessGone(base::TerminationStatus status,