content/browser/frame_host/cross_process_frame_connector.cc - Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/cross_process_frame_connector.cc

diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc

index b56680ddfbc2a0466ab21b1467d4c4e2b4b5abca..6010267d172e33ab0fcae98000eeb3cae8bfac85 100644

--- a/content/browser/frame_host/cross_process_frame_connector.cc

+++ b/content/browser/frame_host/cross_process_frame_connector.cc

@@ -324,7 +324,7 @@ void CrossProcessFrameConnector::SetRect(const gfx::Rect& frame_rect) {

gfx::Rect old_rect = child_frame_rect_;

child_frame_rect_ = frame_rect;

if (view_) {

- view_->SetBounds(frame_rect);

+ view_->RequestTopLevelBoundsInScreen(frame_rect);

// Other local root frames nested underneath this one implicitly have their

// view rects changed when their ancestor is repositioned, and therefore