Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // readback for the frame that is about to be drawn. Once called, the callback 67 // readback for the frame that is about to be drawn. Once called, the callback
68 // pointer is released. 68 // pointer is released.
69 // TODO(wjmaclean): We should consider making this available in other view 69 // TODO(wjmaclean): We should consider making this available in other view
70 // types, such as RenderWidgetHostViewAura. 70 // types, such as RenderWidgetHostViewAura.
71 void RegisterFrameSwappedCallback(std::unique_ptr<base::Closure> callback); 71 void RegisterFrameSwappedCallback(std::unique_ptr<base::Closure> callback);
72 72
73 // RenderWidgetHostView implementation. 73 // RenderWidgetHostView implementation.
74 void InitAsChild(gfx::NativeView parent_view) override; 74 void InitAsChild(gfx::NativeView parent_view) override;
75 RenderWidgetHost* GetRenderWidgetHost() const override; 75 RenderWidgetHost* GetRenderWidgetHost() const override;
76 void SetSize(const gfx::Size& size) override; 76 void SetSize(const gfx::Size& size) override;
77 void SetBounds(const gfx::Rect& rect) override;
78 void Focus() override; 77 void Focus() override;
79 bool HasFocus() const override; 78 bool HasFocus() const override;
80 bool IsSurfaceAvailableForCopy() const override; 79 bool IsSurfaceAvailableForCopy() const override;
81 void Show() override; 80 void Show() override;
82 void Hide() override; 81 void Hide() override;
83 bool IsShowing() override; 82 bool IsShowing() override;
84 gfx::Rect GetViewBounds() const override; 83 gfx::Rect GetViewBounds() const override;
85 gfx::Size GetVisibleViewportSize() const override; 84 gfx::Size GetVisibleViewportSize() const override;
86 gfx::Vector2dF GetLastScrollOffset() const override; 85 gfx::Vector2dF GetLastScrollOffset() const override;
87 gfx::NativeView GetNativeView() const override; 86 gfx::NativeView GetNativeView() const override;
88 gfx::NativeViewAccessible GetNativeViewAccessible() override; 87 gfx::NativeViewAccessible GetNativeViewAccessible() override;
89 void SetBackgroundColor(SkColor color) override; 88 void SetBackgroundColor(SkColor color) override;
90 gfx::Size GetPhysicalBackingSize() const override; 89 gfx::Size GetPhysicalBackingSize() const override;
91 bool IsMouseLocked() override; 90 bool IsMouseLocked() override;
92 void SetNeedsBeginFrames(bool needs_begin_frames) override; 91 void SetNeedsBeginFrames(bool needs_begin_frames) override;
93 92
94 // RenderWidgetHostViewBase implementation. 93 // RenderWidgetHostViewBase implementation.
95 void InitAsPopup(RenderWidgetHostView* parent_host_view, 94 void InitAsPopup(RenderWidgetHostView* parent_host_view,
96 const gfx::Rect& bounds) override; 95 const gfx::Rect& bounds) override;
97 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override; 96 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;
97 void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override;
98 void UpdateCursor(const WebCursor& cursor) override; 98 void UpdateCursor(const WebCursor& cursor) override;
99 void SetIsLoading(bool is_loading) override; 99 void SetIsLoading(bool is_loading) override;
100 void RenderProcessGone(base::TerminationStatus status, 100 void RenderProcessGone(base::TerminationStatus status,
101 int error_code) override; 101 int error_code) override;
102 void Destroy() override; 102 void Destroy() override;
103 void SetTooltipText(const base::string16& tooltip_text) override; 103 void SetTooltipText(const base::string16& tooltip_text) override;
104 void CopyFromCompositingSurface( 104 void CopyFromCompositingSurface(
105 const gfx::Rect& src_subrect, 105 const gfx::Rect& src_subrect,
106 const gfx::Size& dst_size, 106 const gfx::Size& dst_size,
107 const ReadbackRequestCallback& callback, 107 const ReadbackRequestCallback& callback,
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 // The surface client ID of the parent RenderWidgetHostView. 0 if none. 266 // The surface client ID of the parent RenderWidgetHostView. 0 if none.
267 cc::FrameSinkId parent_frame_sink_id_; 267 cc::FrameSinkId parent_frame_sink_id_;
268 268
269 base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_; 269 base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_;
270 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame); 270 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame);
271 }; 271 };
272 272
273 } // namespace content 273 } // namespace content
274 274
275 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 275 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698