Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3716)

Unified Diff: chrome/browser/ui/web_contents_sizer.mm

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/web_contents_sizer.mm
diff --git a/chrome/browser/ui/web_contents_sizer.mm b/chrome/browser/ui/web_contents_sizer.mm
index bdb78960da21d6fdfbe00ae6d7abc452dcfbcb92..fe5af86340e9b47f64f692c8fc3d234320b13a72 100644
--- a/chrome/browser/ui/web_contents_sizer.mm
+++ b/chrome/browser/ui/web_contents_sizer.mm
@@ -10,6 +10,11 @@
void ResizeWebContents(content::WebContents* web_contents,
const gfx::Rect& new_bounds) {
+ // TODO(miu): This direct manipulation of the NSView needs to be removed.
+ // Currently, this is requried because some callers of ResizeWebContents() do
+ // so just after a new WebContents is created, but before the
+ // RenderWidgetHostView for the main frame has not been created yet.
+ // http://crbug.com/693953
NSView* view = web_contents->GetNativeView();
NSRect old_wcv_frame = [view frame];
CGFloat new_x = old_wcv_frame.origin.x;
« no previous file with comments | « chrome/browser/ui/web_contents_sizer.cc ('k') | content/browser/frame_host/cross_process_frame_connector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698