Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2695083002: Revert on M57 "Bind Android ChildProcessServices to a specific client PID." (Closed)

Created:
3 years, 10 months ago by boliu
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert on M57 "Bind Android ChildProcessServices to a specific client PID." Suspect cause of crbug.com/690118 > Bind Android ChildProcessServices to a specific client PID. > > A ChildProcessService may only be setup once, but nothing enforced this limit, > and a second client of the service would receive no indication of failure. This > situation could occur with Android WebView in multi-process mode, if two > android:processes in the same package tried to use WebView. > > To solve this issue, introduce an initial handshake message in > IChildProcessService that must be issued before setupConnection. This method > binds the service to the calling PID. If that binding fails, the > ChildProcessLauncher can then re-try creating a service process using the > next available slot. > > BUG=558377, 683133 > > Review-Url: https://codereview.chromium.org/2626413004 > Cr-Commit-Position: refs/heads/master@{#445779} > (cherry picked from commit abd3ee77b9cfd7b3d8cf5f95c511e328645f8fde) > > Review-Url: https://codereview.chromium.org/2650013003 . > Cr-Commit-Position: refs/branch-heads/2987@{#68} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} BUG=690118 Review-Url: https://codereview.chromium.org/2695083002 . Cr-Commit-Position: refs/branch-heads/2987@{#502} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/fd99e1005540fc3c78c0e4661126b22e86403cff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -437 lines) Patch
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 2 chunks +3 lines, -36 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java View 2 chunks +1 line, -20 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 4 chunks +1 line, -21 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 10 chunks +17 lines, -96 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/IChildProcessService.aidl View 1 chunk +0 lines, -5 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/common/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 3 chunks +0 lines, -147 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java View 2 chunks +6 lines, -8 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -2 lines 0 comments Download
D content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
boliu
3 years, 10 months ago (2017-02-14 18:39:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd99e1005540fc3c78c0e4661126b22e86403cff.

Powered by Google App Engine
This is Rietveld 408576698