Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

Issue 2695083002: Revert on M57 "Bind Android ChildProcessServices to a specific client PID." (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
index 0deff1fa93b9987ad7a3a816b74c37e8ce9c9414..fde50c8f4b2427b5b341b8026ae88bbb11505a8f 100644
--- a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
+++ b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
@@ -53,12 +53,7 @@ import java.util.concurrent.atomic.AtomicReference;
public class ChildProcessServiceImpl {
private static final String MAIN_THREAD_NAME = "ChildProcessMain";
private static final String TAG = "ChildProcessService";
-
- // Lock that protects the following members.
- private final Object mBinderLock = new Object();
private IChildProcessCallback mCallback;
- // PID of the client of this service, set in bindToCaller().
- private int mBoundCallingPid;
// This is the native "Main" thread for the renderer / utility process.
private Thread mMainThread;
@@ -102,38 +97,10 @@ public class ChildProcessServiceImpl {
private final IChildProcessService.Stub mBinder = new IChildProcessService.Stub() {
// NOTE: Implement any IChildProcessService methods here.
@Override
- public boolean bindToCaller() {
- synchronized (mBinderLock) {
- int callingPid = Binder.getCallingPid();
- if (mBoundCallingPid == 0) {
- mBoundCallingPid = callingPid;
- } else if (mBoundCallingPid != callingPid) {
- Log.e(TAG, "Service is already bound by pid %d, cannot bind for pid %d",
- mBoundCallingPid, callingPid);
- return false;
- }
- }
- return true;
- }
-
- @Override
public int setupConnection(Bundle args, IChildProcessCallback callback) {
- int callingPid = Binder.getCallingPid();
- synchronized (mBinderLock) {
- if (mBoundCallingPid != callingPid) {
- if (mBoundCallingPid == 0) {
- Log.e(TAG, "Service has not been bound with bindToCaller()");
- } else {
- Log.e(TAG, "Client pid %d does not match the bound pid %d", callingPid,
- mBoundCallingPid);
- }
- return -1;
- }
-
- mCallback = callback;
- getServiceInfo(args);
- return Process.myPid();
- }
+ mCallback = callback;
+ getServiceInfo(args);
+ return Process.myPid();
}
@Override
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698