Hook up the ANGLE extensions for disabling client-side data.

Hook up the ANGLE extensions for disabling client-side data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2695063003
Cr-Commit-Position: refs/heads/master@{#452542}
Committed: https://chromium.googlesource.com/chromium/src/+/fd848ca355cc7b9034a7883f50ad4f9f5dec1b91

[Geoff Lang, 2017-02-15 16:00:08]

Description was changed from

==========
Hook up the ANGLE extensions for disabling client-side data.

BUG=602737
==========

to

==========
Hook up the ANGLE extensions for disabling client-side data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-15 16:00:48]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 16:01:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 17:35:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 17:36:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Geoff Lang, 2017-02-15 20:11:39]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 20:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 00:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:17:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Geoff Lang, 2017-02-16 15:58:11]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 15:58:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-02-16 15:59:40]

geofflang@chromium.org changed reviewers:
+ jbauman@chromium.org, zmo@chromium.org

[Geoff Lang, 2017-02-16 15:59:41]

PTAL

[commit-bot: I haz the power, 2017-02-16 17:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 17:13:03]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Zhenyao Mo, 2017-02-16 21:59:45]

lgtm

https://codereview.chromium.org/2695063003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc (right):

https://codereview.chromium.org/2695063003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc:181:
glIsEnabled(GL_CLIENT_ARRAYS_ANGLE) != GL_FALSE) {
So context creation should only continue if ANGLE_client_arrays exists but not
enabled?

[Geoff Lang, 2017-02-16 22:08:27]

https://codereview.chromium.org/2695063003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc (right):

https://codereview.chromium.org/2695063003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc:181:
glIsEnabled(GL_CLIENT_ARRAYS_ANGLE) != GL_FALSE) {
On 2017/02/16 21:59:45, Zhenyao Mo wrote:
> So context creation should only continue if ANGLE_client_arrays exists but not
> enabled?

It continues only if the extension exists and the client arrays feature has been
disabled.

[jbauman, 2017-02-17 21:32:11]

lgtm

[Geoff Lang, 2017-02-21 14:44:18]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-02-21 14:44:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:05:40]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Geoff Lang, 2017-02-21 18:41:36]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:42:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-02-21 18:43:05]

geofflang@chromium.org changed reviewers:
+ posciak@chromium.org

[Geoff Lang, 2017-02-21 18:43:05]

posciak: PTAL at rendering_helper.cc/h

[commit-bot: I haz the power, 2017-02-21 22:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:07:27]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2017-02-22 15:33:27]

geofflang@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Geoff Lang, 2017-02-22 15:33:27]

dalecurtis: PTAL at rendering_helper.cc/h

[DaleCurtis, 2017-02-22 17:56:12]

media/ lgtm

[Geoff Lang, 2017-02-22 18:04:15]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-02-22 18:04:16]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2695063003/#ps40001
(title: "Update rendering_helper to use vertex buffers")

[commit-bot: I haz the power, 2017-02-22 18:05:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:13:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Geoff Lang, 2017-02-23 16:03:03]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-02-23 16:03:04]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
jbauman@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2695063003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-23 16:03:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:46:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487865783592140,
"parent_rev": "a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6", "commit_rev":
"fd848ca355cc7b9034a7883f50ad4f9f5dec1b91"}

[commit-bot: I haz the power, 2017-02-23 17:47:31]

Description was changed from

==========
Hook up the ANGLE extensions for disabling client-side data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Hook up the ANGLE extensions for disabling client-side data.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2695063003
Cr-Commit-Position: refs/heads/master@{#452542}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd848ca355cc7b9034a7883f50ad...
==========

[commit-bot: I haz the power, 2017-02-23 17:47:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fd848ca355cc7b9034a7883f50ad...