Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Issue 2695063003: Hook up the ANGLE extensions for disabling client-side data. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | ui/gl/gl_bindings.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h"
6 6
7 #include "base/strings/string_split.h" 7 #include "base/strings/string_split.h"
8 #include "gpu/command_buffer/service/feature_info.h" 8 #include "gpu/command_buffer/service/feature_info.h"
9 #include "gpu/command_buffer/service/gl_utils.h" 9 #include "gpu/command_buffer/service/gl_utils.h"
10 #include "ui/gl/gl_version_info.h" 10 #include "ui/gl/gl_version_info.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 disallowed_features)) { 169 disallowed_features)) {
170 group_ = NULL; // Must not destroy ContextGroup if it is not initialized. 170 group_ = NULL; // Must not destroy ContextGroup if it is not initialized.
171 Destroy(true); 171 Destroy(true);
172 return false; 172 return false;
173 } 173 }
174 174
175 // Check for required extensions 175 // Check for required extensions
176 if (!feature_info_->feature_flags().angle_robust_client_memory || 176 if (!feature_info_->feature_flags().angle_robust_client_memory ||
177 !feature_info_->feature_flags().chromium_bind_generates_resource || 177 !feature_info_->feature_flags().chromium_bind_generates_resource ||
178 !feature_info_->feature_flags().chromium_copy_texture || 178 !feature_info_->feature_flags().chromium_copy_texture ||
179 !feature_info_->feature_flags().chromium_copy_compressed_texture) { 179 !feature_info_->feature_flags().chromium_copy_compressed_texture ||
180 !feature_info_->feature_flags().angle_client_arrays ||
181 glIsEnabled(GL_CLIENT_ARRAYS_ANGLE) != GL_FALSE) {
Zhenyao Mo 2017/02/16 21:59:45 So context creation should only continue if ANGLE_
Geoff Lang 2017/02/16 22:08:26 It continues only if the extension exists and the
180 // TODO(geofflang): Verify that ANGLE_webgl_compatibility is enabled if this 182 // TODO(geofflang): Verify that ANGLE_webgl_compatibility is enabled if this
181 // is a WebGL context (depends on crbug.com/671217). 183 // is a WebGL context (depends on crbug.com/671217).
182 Destroy(true); 184 Destroy(true);
183 return false; 185 return false;
184 } 186 }
185 187
186 image_manager_.reset(new ImageManager()); 188 image_manager_.reset(new ImageManager());
187 189
188 bind_generates_resource_ = group_->bind_generates_resource(); 190 bind_generates_resource_ = group_->bind_generates_resource();
189 191
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 }, /* NOLINT */ 860 }, /* NOLINT */
859 861
860 const GLES2DecoderPassthroughImpl::CommandInfo 862 const GLES2DecoderPassthroughImpl::CommandInfo
861 GLES2DecoderPassthroughImpl::command_info[] = { 863 GLES2DecoderPassthroughImpl::command_info[] = {
862 GLES2_COMMAND_LIST(GLES2_CMD_OP)}; 864 GLES2_COMMAND_LIST(GLES2_CMD_OP)};
863 865
864 #undef GLES2_CMD_OP 866 #undef GLES2_CMD_OP
865 867
866 } // namespace gles2 868 } // namespace gles2
867 } // namespace gpu 869 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | ui/gl/gl_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698