Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: ash/common/system/tray/hover_highlight_view.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/hover_highlight_view.cc
diff --git a/ash/common/system/tray/hover_highlight_view.cc b/ash/common/system/tray/hover_highlight_view.cc
index 7eb36f2776e31b85508761320042235f3058e07a..e83fec28d27fe68b6391d069441a7086d2482828 100644
--- a/ash/common/system/tray/hover_highlight_view.cc
+++ b/ash/common/system/tray/hover_highlight_view.cc
@@ -322,13 +322,17 @@ bool HoverHighlightView::PerformAction(const ui::Event& event) {
void HoverHighlightView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
ActionableView::GetAccessibleNodeData(node_data);
- if (accessibility_state_ == AccessibilityState::CHECKED_CHECKBOX ||
- accessibility_state_ == AccessibilityState::UNCHECKED_CHECKBOX) {
- node_data->role = ui::AX_ROLE_CHECK_BOX;
- }
-
+ int checkedState;
if (accessibility_state_ == AccessibilityState::CHECKED_CHECKBOX)
- node_data->AddStateFlag(ui::AX_STATE_CHECKED);
+ checkedState = ui::AX_CHECKED_STATE_TRUE;
+ else if (accessibility_state_ == AccessibilityState::UNCHECKED_CHECKBOX)
+ checkedState = ui::AX_CHECKED_STATE_FALSE;
+ else
+ return; // Not a checkbox
+
+ // Checkbox
+ node_data->role = ui::AX_ROLE_CHECK_BOX;
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checkedState);
}
gfx::Size HoverHighlightView::GetPreferredSize() const {

Powered by Google App Engine
This is Rietveld 408576698