ash/common/system/ime/tray_ime_chromeos.cc - Issue 2694903010: AX checked state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/ime/tray_ime_chromeos.cc

Issue 2694903010: AX checked state changes (Closed)

Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/ime/tray_ime_chromeos.cc

diff --git a/ash/common/system/ime/tray_ime_chromeos.cc b/ash/common/system/ime/tray_ime_chromeos.cc

index 8b2dca551d5fae56f6e67a014893950718b567f5..7c40af2d0492f57bfb67fb63579765bf18895cb7 100644

--- a/ash/common/system/ime/tray_ime_chromeos.cc

+++ b/ash/common/system/ime/tray_ime_chromeos.cc

@@ -63,8 +63,9 @@ class SelectableHoverHighlightView : public HoverHighlightView {

void GetAccessibleNodeData(ui::AXNodeData* node_data) override {

HoverHighlightView::GetAccessibleNodeData(node_data);

node_data->role = ui::AX_ROLE_CHECK_BOX;

- if (selected_)

- node_data->AddStateFlag(ui::AX_STATE_CHECKED);

+ const int checkedState =

+ selected_ ? ui::AX_CHECKED_STATE_TRUE : ui::AX_CHECKED_STATE_FALSE;

+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checkedState);

}

private: