Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2119)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_list_view.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/ime_menu/ime_list_view.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_list_view.cc b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
index c26468cad1d3d677cfe222cf182755389a0d99c9..e167836ac1099151903942ee386280750d458f7e 100644
--- a/ash/common/system/chromeos/ime_menu/ime_list_view.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
@@ -62,8 +62,9 @@ class SelectableHoverHighlightView : public HoverHighlightView {
void GetAccessibleNodeData(ui::AXNodeData* node_data) override {
HoverHighlightView::GetAccessibleNodeData(node_data);
node_data->role = ui::AX_ROLE_CHECK_BOX;
- if (selected_)
- node_data->AddStateFlag(ui::AX_STATE_CHECKED);
+ const int checkedState =
dmazzoni 2017/03/09 19:33:41 const ui::AXCheckedState checkedState (instead of
aleventhal 2017/03/09 21:40:49 Done.
+ selected_ ? ui::AX_CHECKED_STATE_TRUE : ui::AX_CHECKED_STATE_FALSE;
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checkedState);
}
private:
@@ -157,8 +158,9 @@ class ImeListItemView : public ActionableView {
void GetAccessibleNodeData(ui::AXNodeData* node_data) override {
ActionableView::GetAccessibleNodeData(node_data);
node_data->role = ui::AX_ROLE_CHECK_BOX;
- node_data->AddStateFlag(selected_ ? ui::AX_STATE_CHECKED
- : ui::AX_STATE_NONE);
+ const int checkedState =
dmazzoni 2017/03/09 19:33:41 same
aleventhal 2017/03/09 21:40:49 Done.
+ selected_ ? ui::AX_CHECKED_STATE_TRUE : ui::AX_CHECKED_STATE_FALSE;
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checkedState);
}
private:

Powered by Google App Engine
This is Rietveld 408576698