Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_list_view.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Fix compiler error Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/ime_menu/ime_list_view.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_list_view.cc b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
index 2f2fbf4e9271283c289245a94b013ea2f18b9435..9fd8a22d9f17ee755c6c822f6e95c4e636fafb3d 100644
--- a/ash/common/system/chromeos/ime_menu/ime_list_view.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
@@ -63,7 +63,8 @@ class SelectableHoverHighlightView : public HoverHighlightView {
HoverHighlightView::GetAccessibleNodeData(node_data);
node_data->role = ui::AX_ROLE_CHECK_BOX;
if (selected_)
- node_data->AddStateFlag(ui::AX_STATE_CHECKED);
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,
+ ui::AX_CHECKED_STATE_FALSE);
dmazzoni 2017/02/28 00:10:50 nit: line continuations are indented 4 spaces - bu
}
private:
@@ -157,8 +158,10 @@ class ImeListItemView : public ActionableView {
void GetAccessibleNodeData(ui::AXNodeData* node_data) override {
ActionableView::GetAccessibleNodeData(node_data);
node_data->role = ui::AX_ROLE_CHECK_BOX;
- node_data->AddStateFlag(selected_ ? ui::AX_STATE_CHECKED
- : ui::AX_STATE_NONE);
+ if (selected_) {
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,
+ ui::AX_CHECKED_STATE_FALSE);
+ }
}
private:

Powered by Google App Engine
This is Rietveld 408576698