Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3783)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Fix compiler error Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc b/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
index a7ebfc313d4d25849c2d40e5f5b9ee10d0c16aef..5cb26945a813654bff0da59df1cbf70ac99395a7 100644
--- a/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
@@ -72,7 +72,10 @@ class ImeMenuTrayTest : public test::AshTestBase {
ui::AXNodeData node_data;
node_data.state = 0;
ime.first->GetAccessibleNodeData(&node_data);
- if (node_data.HasStateFlag(ui::AX_STATE_CHECKED)) {
+ const int checkedState =
dmazzoni 2017/02/28 00:10:50 checked_state (variable naming in C++ code)
+ node_data.GetIntAttribute(ui::AX_ATTR_CHECKED_STATE);
+ if (checkedState == ui::AX_CHECKED_STATE_TRUE ||
+ checkedState == ui::AX_CHECKED_STATE_MIXED) {
dmazzoni 2017/02/28 00:10:50 I'd skip MIXED here unless there's any reason to b
if (ime.second != expected_current_ime.id)
return false;
}

Powered by Google App Engine
This is Rietveld 408576698