AX checked state changes

ash/common/system/chromeos/ime_menu/ime_list_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/ime_menu/ime_list_view.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/strings/grit/ash_strings.h"
 #include "ash/common/system/tray/hover_highlight_view.h"
 #include "ash/common/system/tray/ime_info.h"
@@ skipping 45 matching lines @@
   }
 
   ~SelectableHoverHighlightView() override {}
 
  protected:
   // views::View:
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override {
     HoverHighlightView::GetAccessibleNodeData(node_data);
     node_data->role = ui::AX_ROLE_CHECK_BOX;
     if (selected_)
-      node_data->AddStateFlag(ui::AX_STATE_CHECKED);
+      node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,
+        ui::AX_CHECKED_STATE_FALSE);

[dmazzoni, 2017/02/28 00:10:50]

nit: line continuations are indented 4 spaces - but rather
than memorizing, just run "git cl format" and it should
do that automatically

   }
 
  private:
   bool selected_;
 
   DISALLOW_COPY_AND_ASSIGN(SelectableHoverHighlightView);
 };
 
 // The IME list item view used in the material design. It contains IME info
 // (name and label) and a check button if the item is selected. It's also used
@@ skipping 73 matching lines @@
 
   void OnFocus() override {
     ActionableView::OnFocus();
     if (ime_list_view_ && ime_list_view_->scroll_content())
       ime_list_view_->scroll_content()->ScrollRectToVisible(bounds());
   }
 
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override {
     ActionableView::GetAccessibleNodeData(node_data);
     node_data->role = ui::AX_ROLE_CHECK_BOX;
-    node_data->AddStateFlag(selected_ ? ui::AX_STATE_CHECKED
-                                      : ui::AX_STATE_NONE);
+    if (selected_) {
+      node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,
+        ui::AX_CHECKED_STATE_FALSE);
+    }
   }
 
  private:
   ImeListView* ime_list_view_;
   bool selected_;
 
   DISALLOW_COPY_AND_ASSIGN(ImeListItemView);
 };
 
 }  // namespace
@@ skipping 288 matching lines @@
 ImeListViewTestApi::ImeListViewTestApi(ImeListView* ime_list_view)
     : ime_list_view_(ime_list_view) {}
 
 ImeListViewTestApi::~ImeListViewTestApi() {}
 
 views::View* ImeListViewTestApi::GetToggleView() const {
   return ime_list_view_->material_keyboard_status_view_->toggle();
 }
 
 }  // namespace ash