Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2694683002: Ozone Linux: Disable some mash tests causing configuration errors (Closed)

Created:
3 years, 10 months ago by fwang
Modified:
3 years, 10 months ago
Reviewers:
kylechar, sky
CC:
chromium-reviews, tonikitoo, Tom Anderson, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone Linux: Disable some mash tests causing configuration errors After [1], new ChromeOS-specific files are built when enable_package_mash_services=1. This is the case for Ozone Linux and it caused the following error to happen on the build bot: ERROR at //ash/mus/BUILD.gn:11:1: Assertion failed. assert(is_chromeos) ^----- See //services/service_manager/public/service_manifest.gni:136:19: which caused the file to be included. deps += [ manifest_target ] ^-------------- This CL disables corresponding conditionals of [1] when is_chromeos=0 so that Ozone Linux builds again. [1] https://codereview.chromium.org/2680283003/ BUG=664570 Review-Url: https://codereview.chromium.org/2694683002 Cr-Commit-Position: refs/heads/master@{#449961} Committed: https://chromium.googlesource.com/chromium/src/+/59d468305aab2c224ab5bd34a3415869a3e78351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
fwang
PTAL
3 years, 10 months ago (2017-02-13 08:38:15 UTC) #4
kylechar
lgtm
3 years, 10 months ago (2017-02-13 15:13:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694683002/1
3 years, 10 months ago (2017-02-13 15:19:04 UTC) #10
kylechar
Ah sorry, you'll still need an LGTM from sky for the presubmit.
3 years, 10 months ago (2017-02-13 15:19:54 UTC) #11
fwang
On 2017/02/13 15:19:54, kylechar wrote: > Ah sorry, you'll still need an LGTM from sky ...
3 years, 10 months ago (2017-02-13 15:22:18 UTC) #12
kylechar
On 2017/02/13 15:22:18, fwang wrote: > On 2017/02/13 15:19:54, kylechar wrote: > > Ah sorry, ...
3 years, 10 months ago (2017-02-13 15:23:02 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/59d468305aab2c224ab5bd34a3415869a3e78351
3 years, 10 months ago (2017-02-13 15:23:35 UTC) #16
sky
3 years, 10 months ago (2017-02-13 18:01:39 UTC) #17
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698