Switch mash_browser_tests to Ozone X11 platform.

Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570
Review-Url: https://codereview.chromium.org/2680283003
Cr-Commit-Position: refs/heads/master@{#449673}
Committed: https://chromium.googlesource.com/chromium/src/+/309364b3ec8f63807d91ce0eb1985df300155c1a

[kylechar, 2017-02-08 15:28:26]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-02-08 17:20:42]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 17:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 18:38:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 18:38:37]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-02-09 21:07:44]

Description was changed from

==========
Reland of Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall bots build target
all but CQ bots do not. The all target learns about //chrome/app/mash
and the tries to build everything in it. Some of the targets in that
directory aren't suitable to build on Windows which caused the breakage.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall bots build target all
but CQ bots do not. GN learns about //chrome/app/mash and tries to build
all targets in it. Those targets are not suitable for Windows currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

BUG=664570
==========

[kylechar, 2017-02-09 21:10:41]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall bots build target all
but CQ bots do not. GN learns about //chrome/app/mash and tries to build
all targets in it. Those targets are not suitable for Windows currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570
==========

[kylechar, 2017-02-09 21:11:33]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570
==========

[kylechar, 2017-02-09 21:14:40]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-09 21:24:17]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:16:21]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-09 23:55:53]

LGTM

[kylechar, 2017-02-10 18:43:48]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-02-10 18:44:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 18:51:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486752228272720,
"parent_rev": "cc96c42adf22da9c109014c85c6fb11642962e73", "commit_rev":
"309364b3ec8f63807d91ce0eb1985df300155c1a"}

[commit-bot: I haz the power, 2017-02-10 18:53:04]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570

Review-Url: https://codereview.chromium.org/2680283003
Cr-Commit-Position: refs/heads/master@{#449673}
Committed:
https://chromium.googlesource.com/chromium/src/+/309364b3ec8f63807d91ce0eb198...
==========

[commit-bot: I haz the power, 2017-02-10 18:53:05]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/309364b3ec8f63807d91ce0eb198...

[fwang, 2017-02-11 10:39:51]

Description was changed from

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570

Review-Url: https://codereview.chromium.org/2680283003
Cr-Commit-Position: refs/heads/master@{#449673}
Committed:
https://chromium.googlesource.com/chromium/src/+/309364b3ec8f63807d91ce0eb198...
==========

to

==========
Switch mash_browser_tests to Ozone X11 platform.

Run with mash_browser_tests with Ozone X11 platform instead of Ozone
headless. Move most of the test arguments into the gn_isolate_map.pyl
file so they don't have to be repeated. Also add a proper dependency on
mash_service_overrides.json so that isolate knows the file is required
for mash_browser_tests.

Original review in http://crrev.com/2675443002 was reverted due to
breaking the Windows waterfall bots. The waterfall trybots build target
all but CQ trybots do not. GN learns about //chrome/app/mash and tries
to build all targets in it. Those targets are not suitable for Windows
currently.

Guard the compilation of mash_browser_tests and //chrome/app/mash
related code on GN arg enable_package_mash_services. The inclusion of
//chrome/app/mash already happens based on enable_package_mash_services
anyways.

Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of
browser_tests isn't compiled anyways.

BUG=664570

Review-Url: https://codereview.chromium.org/2680283003
Cr-Commit-Position: refs/heads/master@{#449673}
Committed:
https://chromium.googlesource.com/chromium/src/+/309364b3ec8f63807d91ce0eb198...
==========

[fwang, 2017-02-11 10:43:20]

fwang@igalia.com changed reviewers:
+ fwang@igalia.com

[fwang, 2017-02-11 10:43:21]

https://codereview.chromium.org/2680283003/diff/60001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2680283003/diff/60001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:5112: if (enable_package_mash_services) {
Quick note: This and/or the one above have caused "Failed steps failed
generate_build_files" on the LinuxOS Ozone Bot
(https://build.chromium.org/p/chromium.fyi/builders/Ozone%20Linux/) for which
enable_package_mash_services  = true and is_chromeos = false. At least that one
definitely adds //ash dependencies for LinuxOS, which it should not.

[fwang, 2017-02-13 08:37:03]

On 2017/02/11 10:43:21, fwang wrote:
> https://codereview.chromium.org/2680283003/diff/60001/chrome/test/BUILD.gn
> File chrome/test/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2680283003/diff/60001/chrome/test/BUILD.gn#ne...
> chrome/test/BUILD.gn:5112: if (enable_package_mash_services) {
> Quick note: This and/or the one above have caused "Failed steps failed
> generate_build_files" on the LinuxOS Ozone Bot
> (https://build.chromium.org/p/chromium.fyi/builders/Ozone%20Linux/) for which
> enable_package_mash_services  = true and is_chromeos = false. At least that
one
> definitely adds //ash dependencies for LinuxOS, which it should not.

I opened https://codereview.chromium.org/2694683002