Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2694653007: Remove ScopedVector in //components/search_provider_logos (Closed)

Created:
3 years, 10 months ago by ke.he
Modified:
3 years, 10 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector in //components/search_provider_logos BUG=554289 Review-Url: https://codereview.chromium.org/2694653007 Cr-Commit-Position: refs/heads/master@{#450708} Committed: https://chromium.googlesource.com/chromium/src/+/74635441b51ea815077a446193f68d6ac0dd3f30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M components/search_provider_logos/logo_tracker_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ke.he
Hi, Justincohen@, Could you PTAL on this? Thanks!
3 years, 10 months ago (2017-02-15 14:25:58 UTC) #6
justincohen
lgtm
3 years, 10 months ago (2017-02-15 15:06:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694653007/1
3 years, 10 months ago (2017-02-15 15:34:13 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 15:40:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74635441b51ea815077a446193f6...

Powered by Google App Engine
This is Rietveld 408576698