Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Side by Side Diff: components/search_provider_logos/logo_tracker_unittest.cc

Issue 2694653007: Remove ScopedVector in //components/search_provider_logos (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/search_provider_logos/logo_tracker.h" 5 #include "components/search_provider_logos/logo_tracker.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory>
10 #include <vector> 11 #include <vector>
11 12
12 #include "base/base64.h" 13 #include "base/base64.h"
13 #include "base/bind.h" 14 #include "base/bind.h"
14 #include "base/callback.h" 15 #include "base/callback.h"
15 #include "base/files/file_path.h" 16 #include "base/files/file_path.h"
16 #include "base/json/json_writer.h" 17 #include "base/json/json_writer.h"
17 #include "base/memory/ptr_util.h" 18 #include "base/memory/ptr_util.h"
18 #include "base/memory/ref_counted.h" 19 #include "base/memory/ref_counted.h"
19 #include "base/memory/scoped_vector.h"
20 #include "base/run_loop.h" 20 #include "base/run_loop.h"
21 #include "base/strings/string_piece.h" 21 #include "base/strings/string_piece.h"
22 #include "base/strings/stringprintf.h" 22 #include "base/strings/stringprintf.h"
23 #include "base/test/simple_test_clock.h" 23 #include "base/test/simple_test_clock.h"
24 #include "base/threading/thread_task_runner_handle.h" 24 #include "base/threading/thread_task_runner_handle.h"
25 #include "base/time/time.h" 25 #include "base/time/time.h"
26 #include "base/values.h" 26 #include "base/values.h"
27 #include "components/search_provider_logos/google_logo_api.h" 27 #include "components/search_provider_logos/google_logo_api.h"
28 #include "net/base/url_util.h" 28 #include "net/base/url_util.h"
29 #include "net/http/http_response_headers.h" 29 #include "net/http/http_response_headers.h"
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 EXPECT_CALL(*logo_cache_, UpdateCachedLogoMetadata(_)).Times(0); 692 EXPECT_CALL(*logo_cache_, UpdateCachedLogoMetadata(_)).Times(0);
693 EXPECT_CALL(*logo_cache_, SetCachedLogo(_)).Times(0); 693 EXPECT_CALL(*logo_cache_, SetCachedLogo(_)).Times(0);
694 EXPECT_CALL(*logo_cache_, SetCachedLogo(NULL)).Times(AnyNumber()); 694 EXPECT_CALL(*logo_cache_, SetCachedLogo(NULL)).Times(AnyNumber());
695 EXPECT_CALL(*logo_cache_, OnGetCachedLogo()).Times(AtMost(1)); 695 EXPECT_CALL(*logo_cache_, OnGetCachedLogo()).Times(AtMost(1));
696 observer_.ExpectCachedLogo(NULL); 696 observer_.ExpectCachedLogo(NULL);
697 GetLogo(); 697 GetLogo();
698 } 698 }
699 699
700 // Tests that deal with multiple listeners. 700 // Tests that deal with multiple listeners.
701 701
702 void EnqueueObservers(LogoTracker* logo_tracker, 702 void EnqueueObservers(
703 const ScopedVector<MockLogoObserver>& observers, 703 LogoTracker* logo_tracker,
704 size_t start_index) { 704 const std::vector<std::unique_ptr<MockLogoObserver>>& observers,
705 size_t start_index) {
705 if (start_index >= observers.size()) 706 if (start_index >= observers.size())
706 return; 707 return;
707 708
708 logo_tracker->GetLogo(observers[start_index]); 709 logo_tracker->GetLogo(observers[start_index].get());
709 base::ThreadTaskRunnerHandle::Get()->PostTask( 710 base::ThreadTaskRunnerHandle::Get()->PostTask(
710 FROM_HERE, base::Bind(&EnqueueObservers, logo_tracker, 711 FROM_HERE, base::Bind(&EnqueueObservers, logo_tracker,
711 base::ConstRef(observers), start_index + 1)); 712 base::ConstRef(observers), start_index + 1));
712 } 713 }
713 714
714 TEST_F(LogoTrackerTest, SupportOverlappingLogoRequests) { 715 TEST_F(LogoTrackerTest, SupportOverlappingLogoRequests) {
715 Logo cached_logo = GetSampleLogo(logo_url_, test_clock_->Now()); 716 Logo cached_logo = GetSampleLogo(logo_url_, test_clock_->Now());
716 logo_cache_->EncodeAndSetCachedLogo(cached_logo); 717 logo_cache_->EncodeAndSetCachedLogo(cached_logo);
717 ON_CALL(*logo_cache_, SetCachedLogo(_)).WillByDefault(Return()); 718 ON_CALL(*logo_cache_, SetCachedLogo(_)).WillByDefault(Return());
718 719
719 Logo fresh_logo = GetSampleLogo2(logo_url_, test_clock_->Now()); 720 Logo fresh_logo = GetSampleLogo2(logo_url_, test_clock_->Now());
720 std::string response = ServerResponse(fresh_logo); 721 std::string response = ServerResponse(fresh_logo);
721 SetServerResponse(response); 722 SetServerResponse(response);
722 SetServerResponseWhenFingerprint(cached_logo.metadata.fingerprint, response); 723 SetServerResponseWhenFingerprint(cached_logo.metadata.fingerprint, response);
723 724
724 const int kNumListeners = 10; 725 const int kNumListeners = 10;
725 ScopedVector<MockLogoObserver> listeners; 726 std::vector<std::unique_ptr<MockLogoObserver>> listeners;
726 for (int i = 0; i < kNumListeners; ++i) { 727 for (int i = 0; i < kNumListeners; ++i) {
727 MockLogoObserver* listener = new MockLogoObserver(); 728 MockLogoObserver* listener = new MockLogoObserver();
728 listener->ExpectCachedAndFreshLogos(&cached_logo, &fresh_logo); 729 listener->ExpectCachedAndFreshLogos(&cached_logo, &fresh_logo);
729 listeners.push_back(listener); 730 listeners.push_back(base::WrapUnique(listener));
730 } 731 }
731 EnqueueObservers(logo_tracker_, listeners, 0); 732 EnqueueObservers(logo_tracker_, listeners, 0);
732 733
733 EXPECT_CALL(*logo_cache_, SetCachedLogo(_)).Times(AtMost(3)); 734 EXPECT_CALL(*logo_cache_, SetCachedLogo(_)).Times(AtMost(3));
734 EXPECT_CALL(*logo_cache_, OnGetCachedLogo()).Times(AtMost(3)); 735 EXPECT_CALL(*logo_cache_, OnGetCachedLogo()).Times(AtMost(3));
735 736
736 base::RunLoop().RunUntilIdle(); 737 base::RunLoop().RunUntilIdle();
737 } 738 }
738 739
739 TEST_F(LogoTrackerTest, DeleteObserversWhenLogoURLChanged) { 740 TEST_F(LogoTrackerTest, DeleteObserversWhenLogoURLChanged) {
(...skipping 12 matching lines...) Expand all
752 MockLogoObserver listener2; 753 MockLogoObserver listener2;
753 listener2.ExpectFreshLogo(&logo); 754 listener2.ExpectFreshLogo(&logo);
754 logo_tracker_->GetLogo(&listener2); 755 logo_tracker_->GetLogo(&listener2);
755 756
756 base::RunLoop().RunUntilIdle(); 757 base::RunLoop().RunUntilIdle();
757 } 758 }
758 759
759 } // namespace 760 } // namespace
760 761
761 } // namespace search_provider_logos 762 } // namespace search_provider_logos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698