Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 2694633003: [wasm] Rename EmitVarInt to EmitVarUint (Closed)

Created:
3 years, 10 months ago by Clemens Hammacher
Modified:
3 years, 10 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename EmitVarInt to EmitVarUint because that's what it actually does. In the next step, I will introduce EmitVarInt again with the correct semantics, and use it in EmitI32Const and other places where we don't do proper varint encoding currently. R=bradnelson@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2694633003 Cr-Commit-Position: refs/heads/master@{#43198} Committed: https://chromium.googlesource.com/v8/v8/+/94ac7850c451022d56728707c3c08748ec6e0af9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M src/wasm/wasm-module-builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Clemens Hammacher
3 years, 10 months ago (2017-02-13 18:21:32 UTC) #1
titzer
lgtm
3 years, 10 months ago (2017-02-13 18:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694633003/1
3 years, 10 months ago (2017-02-14 17:21:25 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 17:23:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/94ac7850c451022d56728707c3c08748ec6...

Powered by Google App Engine
This is Rietveld 408576698