Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2693993002: [asm-wasm] Fix continue target of do-while loops (Closed)

Created:
3 years, 10 months ago by Clemens Hammacher
Modified:
3 years, 10 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asm-wasm] Fix continue target of do-while loops See associated bug: A continue if a do-while loop did jump back to the loop header, instead of jumping to the condition. This CL fixes this and adds a test case. R=bradnelson@chromium.org, titzer@chromium.org BUG=v8:5912 Review-Url: https://codereview.chromium.org/2693993002 Cr-Commit-Position: refs/heads/master@{#43178} Committed: https://chromium.googlesource.com/v8/v8/+/0b287bd4ea5b799a6686c456ba4e877e65c94c4a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -34 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 1 14 chunks +41 lines, -34 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Clemens Hammacher
3 years, 10 months ago (2017-02-13 18:04:36 UTC) #1
titzer
lgtm with nit https://codereview.chromium.org/2693993002/diff/1/src/asmjs/asm-wasm-builder.cc File src/asmjs/asm-wasm-builder.cc (right): https://codereview.chromium.org/2693993002/diff/1/src/asmjs/asm-wasm-builder.cc#newcode304 src/asmjs/asm-wasm-builder.cc:304: // WASM ifs come with implement ...
3 years, 10 months ago (2017-02-13 18:18:06 UTC) #6
Clemens Hammacher
https://codereview.chromium.org/2693993002/diff/1/src/asmjs/asm-wasm-builder.cc File src/asmjs/asm-wasm-builder.cc (right): https://codereview.chromium.org/2693993002/diff/1/src/asmjs/asm-wasm-builder.cc#newcode304 src/asmjs/asm-wasm-builder.cc:304: // WASM ifs come with implement blocks for both ...
3 years, 10 months ago (2017-02-13 18:23:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693993002/20001
3 years, 10 months ago (2017-02-14 08:55:58 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 08:57:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0b287bd4ea5b799a6686c456ba4e877e65c...

Powered by Google App Engine
This is Rietveld 408576698