DescriptionReland of landing "Fixed title updating for back forward navigation." (patchset #1 id:1 of https://codereview.chromium.org/2689083002/ )
Reason for revert:
This revert did not help. Reverting the revert.
Original issue's description:
> Revert of Relanding "Fixed title updating for back forward navigation." (patchset #3 id:40001 of https://codereview.chromium.org/2691693002/ )
>
> Reason for revert:
> Breaks some other tests this time:
> https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone9-simulator-x64/builds/9939
>
> Original issue's description:
> > Relanding "Fixed title updating for back forward navigation."
> >
> > Chrome relies on KVO compliant "title" property to subscribe for
> > title updates. If this KVO change happens during then navigation
> > it is unclear if title was changes for the previous page, or the
> > navigation was committed and title was changed for the new page.
> >
> > So if there is a navigation in progress WebController should ignore
> > KVO change, but it should always attempt to update title when
> > navigation is committed.
> >
> > BUG=688047, 677356
> >
> > Review-Url: https://codereview.chromium.org/2685803002
> > Cr-Commit-Position: refs/heads/master@{#449527}
> > (cherry picked from commit 487e4cfd53bac5944dad49cbce3b939a0c7bf035)
> >
> > Review-Url: https://codereview.chromium.org/2691693002
> > Cr-Commit-Position: refs/heads/master@{#449828}
> > Committed: https://chromium.googlesource.com/chromium/src/+/adb03a4e58c33d0adc812a2ddae2180abe8ac148
>
> TBR=kkhorimoto@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=688047, 677356
>
> Review-Url: https://codereview.chromium.org/2689083002
> Cr-Commit-Position: refs/heads/master@{#449881}
> Committed: https://chromium.googlesource.com/chromium/src/+/6cc15b2c2eb82ac455cd7dbfe912be9914c1c03d
TBR=kkhorimoto@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=688047, 677356
Review-Url: https://codereview.chromium.org/2694583002
Cr-Commit-Position: refs/heads/master@{#449886}
Committed: https://chromium.googlesource.com/chromium/src/+/176138f21cb2df89eb6157bb748b60207038eff4
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|