Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2689083002: Revert of Relanding "Fixed title updating for back forward navigation." (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Relanding "Fixed title updating for back forward navigation." (patchset #3 id:40001 of https://codereview.chromium.org/2691693002/ ) Reason for revert: Breaks some other tests this time: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone9-simulator-x64/builds/9939 Original issue's description: > Relanding "Fixed title updating for back forward navigation." > > Chrome relies on KVO compliant "title" property to subscribe for > title updates. If this KVO change happens during then navigation > it is unclear if title was changes for the previous page, or the > navigation was committed and title was changed for the new page. > > So if there is a navigation in progress WebController should ignore > KVO change, but it should always attempt to update title when > navigation is committed. > > BUG=688047, 677356 > > Review-Url: https://codereview.chromium.org/2685803002 > Cr-Commit-Position: refs/heads/master@{#449527} > (cherry picked from commit 487e4cfd53bac5944dad49cbce3b939a0c7bf035) > > Review-Url: https://codereview.chromium.org/2691693002 > Cr-Commit-Position: refs/heads/master@{#449828} > Committed: https://chromium.googlesource.com/chromium/src/+/adb03a4e58c33d0adc812a2ddae2180abe8ac148 TBR=kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688047, 677356 Review-Url: https://codereview.chromium.org/2689083002 Cr-Commit-Position: refs/heads/master@{#449881} Committed: https://chromium.googlesource.com/chromium/src/+/6cc15b2c2eb82ac455cd7dbfe912be9914c1c03d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -67 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 3 chunks +25 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 5 chunks +11 lines, -41 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Eugene But (OOO till 7-30)
Created Revert of Relanding "Fixed title updating for back forward navigation."
3 years, 10 months ago (2017-02-12 02:03:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689083002/1
3 years, 10 months ago (2017-02-12 02:03:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6cc15b2c2eb82ac455cd7dbfe912be9914c1c03d
3 years, 10 months ago (2017-02-12 02:05:50 UTC) #6
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-12 04:13:28 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2694583002/ by eugenebut@chromium.org.

The reason for reverting is: This revert did not help. Reverting the revert..

Powered by Google App Engine
This is Rietveld 408576698