Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 269433002: Revert of isActiveFocus() is a more meaningful name (Closed)

Created:
6 years, 7 months ago by bokan
Modified:
6 years, 7 months ago
CC:
blink-reviews, shans, eae+blinkwatch, Steve Block, dino_apple.com, rwlbuis, jamesr, krit, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, rune+blink, danakj, dstockwell, Timothy Loh, Rik, jchaffraix+rendering, ojan, Eric Willigers, rjwright, zoltan1, jbroman, darktears, blink-reviews-rendering, leviw+renderwatch, blink-layers+watch_chromium.org, Mike Lawther (Google), Stephen Chennney, esprehn, Julien - ping for review
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of isActiveFocus() is a more meaningful name (https://codereview.chromium.org/260353003/) Reason for revert: Clearly there's opposition to this naming, best to revert while we discuss. Original issue's description: > isActiveFocus() is a more meaningful name > > Previously the function was named isActive() which > didn't lay emphasis on the behavior and purpose of > the function. There was a FIXME to rename the > function to isActiveFocus(). > > Patch for doing the same. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172911 TBR=jochen@chromium.org,jamesr@chromium.org,pdr@chromium.org,abarth@chromium.org,eseidel@chromium.org,suyash.s@samsung.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/PinchViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/FramelessScrollView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/FramelessScrollView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ScrollbarGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ScrollbarGroup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bokan
Created Revert of isActiveFocus() is a more meaningful name
6 years, 7 months ago (2014-04-30 15:16:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/269433002/1
6 years, 7 months ago (2014-04-30 15:16:45 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 15:17:11 UTC) #3
Message was sent while issue was closed.
Change committed as 172991

Powered by Google App Engine
This is Rietveld 408576698