Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2694243003: Remove ThreadState::m_isAtSafePoint (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ThreadState::m_isAtSafePoint It's safe to remove an !isAtSafePoint() check from isAllocationAllowed() because ThreadState::collectGarbage already enters NoAllocationScope before running a GC. BUG=671856 Review-Url: https://codereview.chromium.org/2694243003 Cr-Commit-Position: refs/heads/master@{#450656} Committed: https://chromium.googlesource.com/chromium/src/+/2a697ce8b8f7be1dbd33c335648b7ce83b1bc71e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M third_party/WebKit/Source/platform/heap/BlinkGCInterruptor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 4 chunks +0 lines, -6 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-15 08:50:11 UTC) #2
sof
lgtm https://codereview.chromium.org/2694243003/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (left): https://codereview.chromium.org/2694243003/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp#oldcode1155 third_party/WebKit/Source/platform/heap/ThreadState.cpp:1155: m_heap->leaveSafePoint(); dead code.
3 years, 10 months ago (2017-02-15 09:00:04 UTC) #3
haraken
https://codereview.chromium.org/2694243003/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (left): https://codereview.chromium.org/2694243003/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp#oldcode1155 third_party/WebKit/Source/platform/heap/ThreadState.cpp:1155: m_heap->leaveSafePoint(); On 2017/02/15 09:00:04, sof wrote: > dead code. ...
3 years, 10 months ago (2017-02-15 09:02:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694243003/1
3 years, 10 months ago (2017-02-15 09:02:52 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 10:43:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a697ce8b8f7be1dbd33c335648b...

Powered by Google App Engine
This is Rietveld 408576698