Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 2694243003: Remove ThreadState::m_isAtSafePoint (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index 2860b2c855581756d1d5312a3f0eee4e27b07b5c..1c28035aec3ff7fdeb33bae770fb5697c55f198b 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -105,7 +105,6 @@ ThreadState::ThreadState()
m_startOfStack(reinterpret_cast<intptr_t*>(WTF::getStackStart())),
m_endOfStack(reinterpret_cast<intptr_t*>(WTF::getStackStart())),
m_safePointScopeMarker(nullptr),
- m_atSafePoint(false),
m_interruptors(),
m_sweepForbidden(false),
m_noAllocationCount(0),
@@ -1104,7 +1103,6 @@ void ThreadState::safePoint(BlinkGC::StackState stackState) {
ThreadHeap::reportMemoryUsageForTracing();
runScheduledGC(stackState);
- ASSERT(!m_atSafePoint);
m_stackState = BlinkGC::HeapPointersOnStack;
}
@@ -1142,8 +1140,6 @@ void ThreadState::enterSafePoint(BlinkGC::StackState stackState,
#endif
ASSERT(stackState == BlinkGC::NoHeapPointersOnStack || scopeMarker);
runScheduledGC(stackState);
- ASSERT(!m_atSafePoint);
- m_atSafePoint = true;
m_stackState = stackState;
m_safePointScopeMarker = scopeMarker;
m_heap->enterSafePoint(this);
@@ -1151,9 +1147,7 @@ void ThreadState::enterSafePoint(BlinkGC::StackState stackState,
void ThreadState::leaveSafePoint() {
ASSERT(checkThread());
- ASSERT(m_atSafePoint);
m_heap->leaveSafePoint();
sof 2017/02/15 09:00:04 dead code.
haraken 2017/02/15 09:02:29 yeah, let me remove this when I remove SafePointSc
- m_atSafePoint = false;
m_stackState = BlinkGC::HeapPointersOnStack;
clearSafePointScopeMarker();
}
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698