Remove thread-local weak processing

Remove thread-local weak processing

It is now unused.

BUG=671856
Review-Url: https://codereview.chromium.org/2694173002
Cr-Commit-Position: refs/heads/master@{#450339}
Committed: https://chromium.googlesource.com/chromium/src/+/6908e6e6a69e1c5b11a7a2227d65a913208bdb95

[haraken, 2017-02-14 06:45:08]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-02-14 06:45:09]

PTAL

[sof, 2017-02-14 07:16:48]

lgtm

https://codereview.chromium.org/2694173002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/2694173002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/Heap.cpp:312: bool
ThreadHeap::popAndInvokeGlobalWeakCallback(Visitor* visitor) {
We should drop the "Global" from some other entry points and names, but later.

https://codereview.chromium.org/2694173002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/Visitor.h (right):

https://codereview.chromium.org/2694173002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/Visitor.h:272: // The weak pointer
callbacks are run on the thread that owns the
nit: refresh this paragraph a bit?

[haraken, 2017-02-14 07:55:52]

>
https://codereview.chromium.org/2694173002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/heap/Visitor.h:272: // The weak pointer
> callbacks are run on the thread that owns the
> nit: refresh this paragraph a bit?

Fixed.

[haraken, 2017-02-14 07:56:05]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-02-14 07:56:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2694173002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2017-02-14 07:56:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 08:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 08:07:25]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2017-02-14 08:29:38]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-02-14 08:29:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2694173002/#ps40001
(title: "temp")

[commit-bot: I haz the power, 2017-02-14 08:29:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 09:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 09:10:55]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[haraken, 2017-02-14 09:43:04]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-02-14 09:43:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2694173002/#ps60001
(title: "temp")

[commit-bot: I haz the power, 2017-02-14 09:43:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 11:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 11:19:20]

Failed to apply patch for third_party/WebKit/Source/platform/heap/Heap.h:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/platform/heap/Heap.h:293
  error: third_party/WebKit/Source/platform/heap/Heap.h: patch does not apply

Patch:       third_party/WebKit/Source/platform/heap/Heap.h
Index: third_party/WebKit/Source/platform/heap/Heap.h
diff --git a/third_party/WebKit/Source/platform/heap/Heap.h
b/third_party/WebKit/Source/platform/heap/Heap.h
index
3e0c63226b5289ab7b07fa8505a63419b9af2c59..2de099f54e3e2798b28f99b572fd4ee4f9e4c2be
100644
--- a/third_party/WebKit/Source/platform/heap/Heap.h
+++ b/third_party/WebKit/Source/platform/heap/Heap.h
@@ -47,6 +47,7 @@
 
 namespace blink {
 
+class CallbackStack;
 class PagePool;
 
 class PLATFORM_EXPORT HeapAllocHooks {
@@ -293,17 +294,6 @@ class PLATFORM_EXPORT ThreadHeap {
   void enterSafePoint(ThreadState*);
   void leaveSafePoint(ThreadState*, SafePointAwareMutexLocker*);
 
-  // Add a weak pointer callback to the weak callback work list.  General
-  // object pointer callbacks are added to a thread local weak callback work
-  // list and the callback is called on the thread that owns the object, with
-  // the closure pointer as an argument.  Most of the time, the closure and
-  // the containerObject can be the same thing, but the containerObject is
-  // constrained to be on the heap, since the heap is used to identify the
-  // correct thread.
-  void pushThreadLocalWeakCallback(void* closure,
-                                   void* containerObject,
-                                   WeakCallback);
-
   static RecursiveMutex& allHeapsMutex();
   static HashSet<ThreadHeap*>& allHeaps();
 
@@ -348,11 +338,9 @@ class PLATFORM_EXPORT ThreadHeap {
   // iteration).
   void pushPostMarkingCallback(void*, TraceCallback);
 
-  // Similar to the more general pushThreadLocalWeakCallback, but cell
-  // pointer callbacks are added to a static callback work list and the weak
-  // callback is performed on the thread performing garbage collection.  This
-  // is OK because cells are just cleared and no deallocation can happen.
-  void pushGlobalWeakCallback(void** cell, WeakCallback);
+  // Push a weak callback. The weak callback is called when the object
+  // doesn't get marked in the current GC.
+  void pushWeakCallback(void*, WeakCallback);
 
   // Pop the top of a marking stack and call the callback with the visitor
   // and the object.  Returns false when there is nothing more to do.

[haraken, 2017-02-14 11:46:35]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-02-14 11:46:35]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2694173002/#ps80001
(title: "temp")

[commit-bot: I haz the power, 2017-02-14 11:46:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 13:39:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487072795049470,
"parent_rev": "36e304bb4631f569e2d811d744eac557adf4ca16", "commit_rev":
"6908e6e6a69e1c5b11a7a2227d65a913208bdb95"}

[commit-bot: I haz the power, 2017-02-14 13:40:08]

Description was changed from

==========
Remove thread-local weak processing

It is now unused.

BUG=671856
==========

to

==========
Remove thread-local weak processing

It is now unused.

BUG=671856

Review-Url: https://codereview.chromium.org/2694173002
Cr-Commit-Position: refs/heads/master@{#450339}
Committed:
https://chromium.googlesource.com/chromium/src/+/6908e6e6a69e1c5b11a7a2227d65...
==========

[commit-bot: I haz the power, 2017-02-14 13:40:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6908e6e6a69e1c5b11a7a2227d65...