Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: third_party/WebKit/Source/platform/heap/VisitorImpl.h

Issue 2694173002: Remove thread-local weak processing (Closed)
Patch Set: temp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Visitor.h ('k') | third_party/WebKit/Source/wtf/HashTable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/VisitorImpl.h
diff --git a/third_party/WebKit/Source/platform/heap/VisitorImpl.h b/third_party/WebKit/Source/platform/heap/VisitorImpl.h
index 276dca8d3c5ddb0e4d615e28cf8838e7ce22c4ee..a746cdef50ba3742553df987645b429e303b5540 100644
--- a/third_party/WebKit/Source/platform/heap/VisitorImpl.h
+++ b/third_party/WebKit/Source/platform/heap/VisitorImpl.h
@@ -56,17 +56,6 @@ inline void Visitor::registerDelayedMarkNoTracing(const void* objectPointer) {
&markNoTracingCallback);
}
-inline void Visitor::registerWeakMembers(const void* closure,
- const void* objectPointer,
- WeakCallback callback) {
- DCHECK(getMarkingMode() != WeakProcessing);
- // We don't want to run weak processings when taking a snapshot.
- if (getMarkingMode() == SnapshotMarking)
- return;
- heap().pushThreadLocalWeakCallback(
- const_cast<void*>(closure), const_cast<void*>(objectPointer), callback);
-}
-
inline void Visitor::registerWeakTable(
const void* closure,
EphemeronCallback iterationCallback,
@@ -99,13 +88,13 @@ inline bool Visitor::ensureMarked(const void* objectPointer) {
return true;
}
-inline void Visitor::registerWeakCellWithCallback(void** cell,
- WeakCallback callback) {
+inline void Visitor::registerWeakCallback(void* closure,
+ WeakCallback callback) {
DCHECK(getMarkingMode() != WeakProcessing);
// We don't want to run weak processings when taking a snapshot.
if (getMarkingMode() == SnapshotMarking)
return;
- heap().pushGlobalWeakCallback(cell, callback);
+ heap().pushWeakCallback(closure, callback);
}
inline void Visitor::registerBackingStoreReference(void* slot) {
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Visitor.h ('k') | third_party/WebKit/Source/wtf/HashTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698