Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2694163004: Use fallback capabilities for devices that cannot list camera capabilities. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fallback capabilities for devices that cannot list camera capabilities. The lack of the fallback made getUserMedia() fail on a number of devices. The fallback code already exists in media_stream_video_capturer_source.cc, but it will be removed from there once all the settings produced by the spec-compliant algorithm are used to configure video sources. Test CL: https://codereview.chromium.org/2692883004/ BUG=691559 Review-Url: https://codereview.chromium.org/2694163004 Cr-Commit-Position: refs/heads/master@{#450373} Committed: https://chromium.googlesource.com/chromium/src/+/0725c8fd30b4076ecf805d4fab57a6eb4cc6e7f4

Patch Set 1 #

Patch Set 2 : rename constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M content/browser/renderer_host/media/media_devices_dispatcher_host.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Guido Urdaneta
Hi, PTAL
3 years, 10 months ago (2017-02-14 14:13:40 UTC) #3
hbos_chromium
lgtm. Can you add a test case for such devices? Preferably in this CL but ...
3 years, 10 months ago (2017-02-14 14:20:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694163004/20001
3 years, 10 months ago (2017-02-14 15:26:28 UTC) #8
Guido Urdaneta
On 2017/02/14 14:20:22, hbos_chromium wrote: > lgtm. > > Can you add a test case ...
3 years, 10 months ago (2017-02-14 15:59:23 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 16:19:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0725c8fd30b4076ecf805d4fab57...

Powered by Google App Engine
This is Rietveld 408576698