Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2692883004: Allow FakeVideoCaptureDeviceFactory to specify number of supported formats per device. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow FakeVideoCaptureDeviceFactory to specify number of supported formats per device. This is intended to allow testing that devices that cannot provide their supported formats get a fallback list of supported formats in MediaDevicesDispatcherHost. BUG=691559

Patch Set 1 #

Patch Set 2 : update comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -6 lines) Patch
M content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download
M media/capture/video/fake_video_capture_device_factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M media/capture/video/fake_video_capture_device_factory.cc View 4 chunks +17 lines, -3 lines 1 comment Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Guido Urdaneta
Hi, PTAL
3 years, 10 months ago (2017-02-14 15:22:22 UTC) #2
mcasas
https://codereview.chromium.org/2692883004/diff/40001/media/capture/video/fake_video_capture_device_factory.cc File media/capture/video/fake_video_capture_device_factory.cc (right): https://codereview.chromium.org/2692883004/diff/40001/media/capture/video/fake_video_capture_device_factory.cc#newcode169 media/capture/video/fake_video_capture_device_factory.cc:169: } I think adding a new command line flag ...
3 years, 10 months ago (2017-02-14 17:01:01 UTC) #7
chfremer
On 2017/02/14 15:22:22, Guido Urdaneta wrote: > Hi, PTAL As an FYI, I have done ...
3 years, 10 months ago (2017-02-14 17:30:37 UTC) #8
Guido Urdaneta
On 2017/02/14 17:30:37, chfremer wrote: > On 2017/02/14 15:22:22, Guido Urdaneta wrote: > > Hi, ...
3 years, 10 months ago (2017-02-14 21:31:14 UTC) #9
chfremer
On 2017/02/14 21:31:14, Guido Urdaneta wrote: > On 2017/02/14 17:30:37, chfremer wrote: > > On ...
3 years, 10 months ago (2017-02-14 23:27:34 UTC) #10
Guido Urdaneta
3 years, 10 months ago (2017-02-15 10:39:37 UTC) #12
Message was sent while issue was closed.
Closed. Will revisit once chfremer's refactoring lands.

Powered by Google App Engine
This is Rietveld 408576698