Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2694113002: Delete media/base/yuv_convert and dependents. Prefer libyuv. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete media/base/yuv_convert and dependents. Prefer libyuv. libyuv has equivalent functionality for all functions now, stop maintaining our own versions! BUG=158462 TEST=none Review-Url: https://codereview.chromium.org/2694113002 Cr-Commit-Position: refs/heads/master@{#450210} Committed: https://chromium.googlesource.com/chromium/src/+/6e361a1ded1c63b390f686fdab4903e18cbab35b

Patch Set 1 : Fix media_unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5030 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 2 chunks +11 lines, -15 lines 0 comments Download
M media/base/BUILD.gn View 9 chunks +1 line, -88 lines 0 comments Download
M media/base/media.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv.h View 1 chunk +0 lines, -79 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_c.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_sse2.cc View 1 chunk +0 lines, -419 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_ssse3.h View 1 chunk +0 lines, -43 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_ssse3.asm View 1 chunk +0 lines, -318 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_ssse3.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_ssse3.inc View 1 chunk +0 lines, -200 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_unittest.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D media/base/simd/convert_yuv_to_rgb.h View 1 chunk +0 lines, -169 lines 0 comments Download
D media/base/simd/convert_yuv_to_rgb_c.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D media/base/simd/convert_yuv_to_rgb_mmx.inc View 1 chunk +0 lines, -63 lines 0 comments Download
D media/base/simd/convert_yuv_to_rgb_sse.asm View 1 chunk +0 lines, -24 lines 0 comments Download
D media/base/simd/convert_yuv_to_rgb_x86.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D media/base/simd/convert_yuva_to_argb_mmx.asm View 1 chunk +0 lines, -24 lines 0 comments Download
D media/base/simd/convert_yuva_to_argb_mmx.inc View 1 chunk +0 lines, -114 lines 0 comments Download
D media/base/simd/empty_register_state_mmx.asm View 1 chunk +0 lines, -24 lines 0 comments Download
D media/base/simd/filter_yuv.h View 1 chunk +0 lines, -31 lines 0 comments Download
D media/base/simd/filter_yuv_c.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D media/base/simd/filter_yuv_sse2.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D media/base/simd/linear_scale_yuv_to_rgb_mmx.asm View 1 chunk +0 lines, -24 lines 0 comments Download
D media/base/simd/linear_scale_yuv_to_rgb_mmx.inc View 1 chunk +0 lines, -135 lines 0 comments Download
D media/base/simd/linear_scale_yuv_to_rgb_mmx_x64.asm View 1 chunk +0 lines, -152 lines 0 comments Download
D media/base/simd/linear_scale_yuv_to_rgb_sse.asm View 1 chunk +0 lines, -23 lines 0 comments Download
D media/base/simd/media_export.asm View 1 chunk +0 lines, -48 lines 0 comments Download
D media/base/simd/scale_yuv_to_rgb_mmx.asm View 1 chunk +0 lines, -24 lines 0 comments Download
D media/base/simd/scale_yuv_to_rgb_mmx.inc View 1 chunk +0 lines, -98 lines 0 comments Download
D media/base/simd/scale_yuv_to_rgb_sse.asm View 1 chunk +0 lines, -24 lines 0 comments Download
D media/base/simd/scale_yuv_to_rgb_sse2_x64.asm View 1 chunk +0 lines, -113 lines 0 comments Download
D media/base/simd/xcode_hack.c View 1 chunk +0 lines, -10 lines 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M media/base/video_util.cc View 2 chunks +9 lines, -15 lines 0 comments Download
D media/base/yuv_convert.h View 1 chunk +0 lines, -152 lines 0 comments Download
D media/base/yuv_convert.cc View 1 chunk +0 lines, -734 lines 0 comments Download
D media/base/yuv_convert_perftest.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D media/base/yuv_convert_unittest.cc View 1 chunk +0 lines, -876 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
DaleCurtis
Bots are looking good, so +bbudge for content/renderer/pepper and +fbarchard for overall approval.
3 years, 10 months ago (2017-02-14 00:32:19 UTC) #5
fbarchard1
lgtm
3 years, 10 months ago (2017-02-14 00:44:08 UTC) #7
bbudge
content/renderer/pepper lgtm
3 years, 10 months ago (2017-02-14 00:53:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694113002/20001
3 years, 10 months ago (2017-02-14 01:36:02 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 02:47:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6e361a1ded1c63b390f686fdab49...

Powered by Google App Engine
This is Rietveld 408576698