Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2694093002: Add a use counter and histogram to FileReaderSync. (Closed)

Created:
3 years, 10 months ago by Marijn Kruisselbrink
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add a use counter and histogram to FileReaderSync. To hopefully eventually facilitate removing FileReaderSync from service workers this adds both a use counter and histogram to log how often the API is used in the various worker types. BUG=688586 Review-Url: https://codereview.chromium.org/2682223006 Cr-Commit-Position: refs/heads/master@{#449833} (cherry picked from commit 77f740e334ba6fdb4d6493372e8009c544939ed4) Review-Url: https://codereview.chromium.org/2694093002 . Cr-Commit-Position: refs/branch-heads/2987@{#489} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f9a5a3f987c9c5c4af122effef4440d97838e568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReaderSync.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 1 chunk +27 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marijn Kruisselbrink
3 years, 10 months ago (2017-02-13 21:57:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9a5a3f987c9c5c4af122effef4440d97838e568.

Powered by Google App Engine
This is Rietveld 408576698