Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2682223006: Add a use counter and histogram to FileReaderSync. (Closed)

Created:
3 years, 10 months ago by Marijn Kruisselbrink
Modified:
3 years, 10 months ago
Reviewers:
kinuko, Mark P
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use counter and histogram to FileReaderSync. To hopefully eventually facilitate removing FileReaderSync from service workers this adds both a use counter and histogram to log how often the API is used in the various worker types. BUG=688586 Review-Url: https://codereview.chromium.org/2682223006 Cr-Commit-Position: refs/heads/master@{#449833} Committed: https://chromium.googlesource.com/chromium/src/+/77f740e334ba6fdb4d6493372e8009c544939ed4

Patch Set 1 #

Patch Set 2 : add new histogram to histograms.xml #

Total comments: 6

Patch Set 3 : explicit #

Total comments: 9

Patch Set 4 : Reorder histogram enum #

Patch Set 5 : clarify histogram description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReaderSync.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 1 2 3 1 chunk +27 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (23 generated)
Marijn Kruisselbrink
3 years, 10 months ago (2017-02-09 23:40:57 UTC) #9
kinuko
lgtm https://codereview.chromium.org/2682223006/diff/40001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp File third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp (right): https://codereview.chromium.org/2682223006/diff/40001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp#newcode50 third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp:50: OTHER = 3, nit: as far as we ...
3 years, 10 months ago (2017-02-10 00:41:39 UTC) #10
Marijn Kruisselbrink
https://codereview.chromium.org/2682223006/diff/40001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp File third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp (right): https://codereview.chromium.org/2682223006/diff/40001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp#newcode50 third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp:50: OTHER = 3, On 2017/02/10 at 00:41:38, kinuko wrote: ...
3 years, 10 months ago (2017-02-10 17:42:53 UTC) #14
Mark P
https://codereview.chromium.org/2682223006/diff/60001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp File third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp (right): https://codereview.chromium.org/2682223006/diff/60001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp#newcode50 third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp:50: OTHER = 3, OTHER sounds like a miscellaneous bucket. ...
3 years, 10 months ago (2017-02-10 22:56:42 UTC) #18
Marijn Kruisselbrink
https://codereview.chromium.org/2682223006/diff/60001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp File third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp (right): https://codereview.chromium.org/2682223006/diff/60001/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp#newcode50 third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp:50: OTHER = 3, On 2017/02/10 at 22:56:42, Mark P ...
3 years, 10 months ago (2017-02-10 23:17:28 UTC) #20
Mark P
lgtm modulo nits --mark https://codereview.chromium.org/2682223006/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2682223006/diff/60001/tools/metrics/histograms/histograms.xml#newcode19450 tools/metrics/histograms/histograms.xml:19450: + How often which worker ...
3 years, 10 months ago (2017-02-10 23:42:35 UTC) #22
Marijn Kruisselbrink
https://codereview.chromium.org/2682223006/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2682223006/diff/60001/tools/metrics/histograms/histograms.xml#newcode19450 tools/metrics/histograms/histograms.xml:19450: + How often which worker types create FileReaderSync instances. ...
3 years, 10 months ago (2017-02-11 00:09:20 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682223006/100001
3 years, 10 months ago (2017-02-11 00:54:27 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/77f740e334ba6fdb4d6493372e8009c544939ed4
3 years, 10 months ago (2017-02-11 02:21:38 UTC) #32
Mark P
3 years, 10 months ago (2017-02-11 05:00:05 UTC) #33
Message was sent while issue was closed.
https://codereview.chromium.org/2682223006/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2682223006/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:19450: +    How often which worker types
create FileReaderSync instances.
> Btw, was the histogram guidelines doc ever shared on chromium-dev? Seems like
> that could be useful, especially as it has a bunch of advise/policies that as
> far as I know weren't strongly enforced (or certainly not documented) earlier.
> Making sure people know about the policies could probably help make reviews go
> more smoothly...

No, it wasn't.  That's a good idea.  Thanks!  I'll do it sometime this month.

Powered by Google App Engine
This is Rietveld 408576698