Add NoStatePrefetch to field_trial_testing_config.json

Add NoStatePrefetch to field_trial_testing_config.json

Review-Url: https://codereview.chromium.org/2693983002
Cr-Commit-Position: refs/heads/master@{#451178}
Committed: https://chromium.googlesource.com/chromium/src/+/a255f7468a598ea8cf8a5ab0e21ab0047f52568a

[droger, 2017-02-14 09:29:06]

droger@chromium.org changed reviewers:
+ pasko@chromium.org, rkaplow@chromium.org

[pasko, 2017-02-14 12:16:35]

non-owner lgtm

[droger, 2017-02-14 12:17:03]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 12:17:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 13:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 13:38:40]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[droger, 2017-02-14 14:42:09]

Looks like this is actually breaking CustomTabs tests, I'll investigate.

[droger, 2017-02-14 16:06:23]

droger@chromium.org changed reviewers:
+ lizeb@chromium.org

[droger, 2017-02-14 16:06:24]

+lizeb for custom tabs:
enabling no-state prefetch by default breaks some customtabs tests. I'm fixing
these by setting the "prerenderOnCellular" parameter to true.
I have a related question below:

https://codereview.chromium.org/2693983002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
(right):

https://codereview.chromium.org/2693983002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:2119:
// setShouldPrerenderOnCellularForSession(token, true);
lizeb: I'm a bit confused, is there a way to call
setShouldPrerenderOnCellularForSession() from here?

[rkaplow, 2017-02-14 16:29:53]

lgtm

config part lg

[droger, 2017-02-16 12:28:53]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 12:29:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2017-02-16 12:47:03]

Patchset #3 (id:40001) has been deleted

[droger, 2017-02-16 12:47:10]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-02-16 13:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 13:11:31]

Dry run: This issue passed the CQ dry run.

[droger, 2017-02-16 13:15:22]

lizeb: all tests pass, can you review the CustomTabs changes?

[Benoit L, 2017-02-16 17:03:21]

Thanks!
customtabs/ LGTM

[droger, 2017-02-16 17:05:12]

The CQ bit was checked by droger@chromium.org

[droger, 2017-02-16 17:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2693983002/#ps100001
(title: "Complete fix")

[commit-bot: I haz the power, 2017-02-16 17:05:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 17:14:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 17:14:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[droger, 2017-02-16 17:21:38]

droger@chromium.org changed reviewers:
+ dtrainor@chromium.org

[droger, 2017-02-16 17:21:39]

+dtrainor as OWNER for:
ExternalPrerenderHandlerTest.java
PrerenderTestHelper.java

[David Trainor- moved to gerrit, 2017-02-16 18:23:22]

lgtm!

[droger, 2017-02-17 01:14:14]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2017-02-17 01:15:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:12:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487294054355360,
"parent_rev": "4d81d1e61673e8e3f988fe8efaebf630308f8e85", "commit_rev":
"a255f7468a598ea8cf8a5ab0e21ab0047f52568a"}

[commit-bot: I haz the power, 2017-02-17 02:12:58]

Description was changed from

==========
Add NoStatePrefetch to field_trial_testing_config.json
==========

to

==========
Add NoStatePrefetch to field_trial_testing_config.json

Review-Url: https://codereview.chromium.org/2693983002
Cr-Commit-Position: refs/heads/master@{#451178}
Committed:
https://chromium.googlesource.com/chromium/src/+/a255f7468a598ea8cf8a5ab0e21a...
==========

[commit-bot: I haz the power, 2017-02-17 02:13:00]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a255f7468a598ea8cf8a5ab0e21a...