headless: Add support for minidump generation on Linux

headless: Add support for minidump generation on Linux

This patch adds support for minidump generation in headless mode. This
is controlled by two new browser settings:

- SetCrashReporterEnabled: Turns crash reporter on or off. Off by
  default.
- SetCrashDumpsDir: Controls where crash dumps are written. Uses the
  directory of the executable by default.

Headless Shell is also modified to accept the equivalent command line
flags: --enable-crash-reporter and --crash-dumps-dir. Note that we don't
enable crash dumps automatically because we currently can't determine
whether the user has opted into metrics reporting.

In official builds, the generated minidumps are also uploaded
automatically. This can be disabled either with --disable-breakpad or by
setting the CHROME_HEADLESS environment variable to indicate an
unattended testing mode (as with regular Chrome).

Design doc:
https://docs.google.com/document/d/1l6AGOOBLk99PaAKoZQW_DVhM8FQ6Fut27lD938CRbTM/edit#

BUG=691507
Review-Url: https://codereview.chromium.org/2693943004
Cr-Commit-Position: refs/heads/master@{#450655}
Committed: https://chromium.googlesource.com/chromium/src/+/c3c9701cc44e6cb38e78c8e1d9d2bca5a74726a4

[Sami, 2017-02-14 13:30:14]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 13:30:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-02-14 13:30:32]

Description was changed from

==========
headless: Add support for minidump generation on Linux

This patch adds support for minidump generation in headless mode. This
is controlled by two new browser settings:

- SetCrashReporterEnabled: Turns crash reporter on or off. Off by
  default.
- SetCrashDumpsDir: Controls where crash dumps are written. Uses the
  directory of the executable by default.

Headless Shell is also modified to accept the equivalent command line
flags: --enable-crash-reporter and --crash-dumps-dir. Note that we don't
enable crash dumps automatically because we currently can't determine
whether the user has opted into metrics reporting.

In official builds, the generated minidumps are also uploaded
automatically. This can be disabled either with --disable-breakpad or by
setting the CHROME_HEADLESS environment variable to indicate an
unattended testing mode (as with regular Chrome).

Design doc:
https://docs.google.com/document/d/1l6AGOOBLk99PaAKoZQW_DVhM8FQ6Fut27lD938CRb...

BUG=691507
==========

to

==========
headless: Add support for minidump generation on Linux

This patch adds support for minidump generation in headless mode. This
is controlled by two new browser settings:

- SetCrashReporterEnabled: Turns crash reporter on or off. Off by
  default.
- SetCrashDumpsDir: Controls where crash dumps are written. Uses the
  directory of the executable by default.

Headless Shell is also modified to accept the equivalent command line
flags: --enable-crash-reporter and --crash-dumps-dir. Note that we don't
enable crash dumps automatically because we currently can't determine
whether the user has opted into metrics reporting.

In official builds, the generated minidumps are also uploaded
automatically. This can be disabled either with --disable-breakpad or by
setting the CHROME_HEADLESS environment variable to indicate an
unattended testing mode (as with regular Chrome).

Design doc:
https://docs.google.com/document/d/1l6AGOOBLk99PaAKoZQW_DVhM8FQ6Fut27lD938CRb...

BUG=691507
==========

[Sami, 2017-02-14 13:30:32]

skyostil@chromium.org changed reviewers:
+ alexclarke@chromium.org, altimin@chromium.org, eseckler@chromium.org

[Sami, 2017-02-14 13:30:43]

PTAL.

[commit-bot: I haz the power, 2017-02-14 14:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 14:34:41]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2017-02-14 15:14:08]

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_content_browser_client.cc (right):

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_content_browser_client.cc:176: #if
defined(OS_POSIX) && !defined(OS_MACOSX)
Does the crash pad code typically use this pre-processor expression everywhere? 
Is it worth defining a USE_BREAKPAD pre-processor variable?

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/headless_b...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/headless_b...
headless/lib/headless_browser_browsertest.cc:701:
HeadlessBrowserContext::Builder builder =
Do we need this temporary?

[Eric Seckler, 2017-02-14 18:05:06]

lgtm with Alex' nits :)

[Sami, 2017-02-14 18:26:57]

Patchset #3 (id:40001) has been deleted

[Sami, 2017-02-14 18:34:30]

Patchset #3 (id:60001) has been deleted

[Sami, 2017-02-14 18:36:10]

skyostil@chromium.org changed reviewers:
+ jochen@chromium.org

[Sami, 2017-02-14 18:36:47]

Thanks!

Jochen, could you stamp the new dep on components/crash/content/{app,browser}?
Other input is welcome too obviously.

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_content_browser_client.cc (right):

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_content_browser_client.cc:176: #if
defined(OS_POSIX) && !defined(OS_MACOSX)
On 2017/02/14 15:14:08, alex clarke wrote:
> Does the crash pad code typically use this pre-processor expression
everywhere? 
> Is it worth defining a USE_BREAKPAD pre-processor variable?

Good point, I copied this pattern from content/ and chrome/. USE_BREAKPAD sounds
cleaner, done.

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/headless_b...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2693943004/diff/20001/headless/lib/headless_b...
headless/lib/headless_browser_browsertest.cc:701:
HeadlessBrowserContext::Builder builder =
On 2017/02/14 15:14:08, alex clarke wrote:
> Do we need this temporary?

Not really, removed.

[Sami, 2017-02-14 18:36:51]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 18:37:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 20:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:14:37]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-15 09:47:38]

lgtm

I see you have a test \o/

[Sami, 2017-02-15 10:31:37]

On 2017/02/15 09:47:38, jochen wrote:
> lgtm
> 
> I see you have a test \o/

Were you expecting otherwise? :D Thanks.

[Sami, 2017-02-15 10:31:42]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-02-15 10:31:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
eseckler@chromium.org
Link to the patchset: https://codereview.chromium.org/2693943004/#ps80001
(title: "Review comments")

[commit-bot: I haz the power, 2017-02-15 10:32:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 10:37:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487154702349100,
"parent_rev": "a97d64509b72ffc3f69ab86d57b2d45536a8b60f", "commit_rev":
"c3c9701cc44e6cb38e78c8e1d9d2bca5a74726a4"}

[commit-bot: I haz the power, 2017-02-15 10:38:01]

Description was changed from

==========
headless: Add support for minidump generation on Linux

This patch adds support for minidump generation in headless mode. This
is controlled by two new browser settings:

- SetCrashReporterEnabled: Turns crash reporter on or off. Off by
  default.
- SetCrashDumpsDir: Controls where crash dumps are written. Uses the
  directory of the executable by default.

Headless Shell is also modified to accept the equivalent command line
flags: --enable-crash-reporter and --crash-dumps-dir. Note that we don't
enable crash dumps automatically because we currently can't determine
whether the user has opted into metrics reporting.

In official builds, the generated minidumps are also uploaded
automatically. This can be disabled either with --disable-breakpad or by
setting the CHROME_HEADLESS environment variable to indicate an
unattended testing mode (as with regular Chrome).

Design doc:
https://docs.google.com/document/d/1l6AGOOBLk99PaAKoZQW_DVhM8FQ6Fut27lD938CRb...

BUG=691507
==========

to

==========
headless: Add support for minidump generation on Linux

This patch adds support for minidump generation in headless mode. This
is controlled by two new browser settings:

- SetCrashReporterEnabled: Turns crash reporter on or off. Off by
  default.
- SetCrashDumpsDir: Controls where crash dumps are written. Uses the
  directory of the executable by default.

Headless Shell is also modified to accept the equivalent command line
flags: --enable-crash-reporter and --crash-dumps-dir. Note that we don't
enable crash dumps automatically because we currently can't determine
whether the user has opted into metrics reporting.

In official builds, the generated minidumps are also uploaded
automatically. This can be disabled either with --disable-breakpad or by
setting the CHROME_HEADLESS environment variable to indicate an
unattended testing mode (as with regular Chrome).

Design doc:
https://docs.google.com/document/d/1l6AGOOBLk99PaAKoZQW_DVhM8FQ6Fut27lD938CRb...

BUG=691507

Review-Url: https://codereview.chromium.org/2693943004
Cr-Commit-Position: refs/heads/master@{#450655}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3c9701cc44e6cb38e78c8e1d9d2...
==========

[commit-bot: I haz the power, 2017-02-15 10:38:02]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c3c9701cc44e6cb38e78c8e1d9d2...