headless/lib/embedder_mojo_browsertest.cc - Issue 2693943004: headless: Add support for minidump generation on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/embedder_mojo_browsertest.cc

Issue 2693943004: headless: Add support for minidump generation on Linux (Closed)

Patch Set: Review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/embedder_mojo_browsertest.cc

diff --git a/headless/lib/embedder_mojo_browsertest.cc b/headless/lib/embedder_mojo_browsertest.cc

index 92800f1acc35b41be6966362a113cfc28c740839..51cc2cb63ff1dac58997bf6ab078f63ce90ed5e7 100644

--- a/headless/lib/embedder_mojo_browsertest.cc

+++ b/headless/lib/embedder_mojo_browsertest.cc

@@ -66,7 +66,7 @@ class EmbedderMojoTest : public HeadlessBrowserTest,

pak_path, ui::SCALE_FACTOR_NONE);

}

- // HeadlessWebContentsObserver implementation:

+ // HeadlessWebContents::Observer implementation:

void DevToolsTargetReady() override {

EXPECT_TRUE(web_contents_->GetDevToolsTarget());

web_contents_->GetDevToolsTarget()->AttachClient(devtools_client_.get());