Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromium_issues.txt

Issue 2693893009: [NOT FOR COMMINT] Linter for RunShellCommand calls (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cataput_issues.txt ('k') | lint_shell_commands.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromium_issues.txt
diff --git a/chromium_issues.txt b/chromium_issues.txt
new file mode 100644
index 0000000000000000000000000000000000000000..07b49fc23900c373777a916d417152653d82c822
--- /dev/null
+++ b/chromium_issues.txt
@@ -0,0 +1,69 @@
+WARNING:build/android/provision_devices.py:413: Avoid passing command as a string.
+WARNING:build/android/provision_devices.py:421: Missing check_return=True.
+WARNING:build/android/provision_devices.py:191: Avoid passing command as a string.
+WARNING:build/android/provision_devices.py:423: Missing check_return=True.
+WARNING:build/android/provision_devices.py:390: Missing check_return=True.
+WARNING:build/android/enable_asserts.py:45: Avoid passing command as a string.
+WARNING:build/android/enable_asserts.py:45: Missing check_return=True.
+WARNING:build/android/enable_asserts.py:46: Avoid passing command as a string.
+WARNING:build/android/enable_asserts.py:46: Missing check_return=True.
+WARNING:build/android/gyp/push_libraries.py:43: Missing check_return=True.
+WARNING:build/android/gyp/util/build_device.py:36: Missing check_return=True.
+WARNING:build/android/pylib/device_settings.py:98: Missing check_return=True.
+WARNING:build/android/pylib/content_settings.py:35: Missing check_return=True.
+WARNING:build/android/pylib/content_settings.py:75: Missing check_return=True.
+WARNING:build/android/pylib/content_settings.py:59: Missing check_return=True.
+WARNING:build/android/pylib/content_settings.py:66: Missing check_return=True.
+WARNING:build/android/pylib/content_settings.py:53: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:23: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:104: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:106: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:117: Avoid passing command as a string.
+WARNING:build/android/pylib/valgrind_tools.py:117: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:118: Avoid passing command as a string.
+WARNING:build/android/pylib/valgrind_tools.py:118: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:120: Missing check_return=True.
+WARNING:build/android/pylib/valgrind_tools.py:127: Missing check_return=True.
+WARNING:build/android/pylib/local/device/local_device_monkey_test_run.py:117: Missing check_return=True.
+WARNING:build/android/pylib/local/device/local_device_gtest_run.py:237: Consider switching check_return=False to True.
+WARNING:build/android/pylib/local/device/local_device_instrumentation_test_run.py:353: Missing check_return=True.
+WARNING:skia/tools/clusterfuzz-data/fuzzers/mbarbella_webgl/shader_generator.py: Parse error, skipping.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:54: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:54: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:79: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:82: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:105: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:109: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:155: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:155: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:267: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:268: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:438: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:456: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:456: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:462: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:462: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:86: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:86: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:458: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:458: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:459: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:459: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:464: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:464: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:465: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:465: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:342: Avoid passing command as a string.
+WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py:342: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/run.py:142: Missing check_return=True.
+WARNING:components/cronet/android/test/javaperftests/run.py:240: Missing check_return=True.
+WARNING:v8/src/js/macros.py: Parse error, skipping.
+WARNING:v8/tools/gen-inlining-tests.py: Parse error, skipping.
+WARNING:v8/tools/run_perf.py:703: Missing check_return=True.
+WARNING:v8/tools/run_perf.py:796: Missing check_return=True.
+WARNING:tools/android/appstats.py:212: Missing check_return=True.
+WARNING:tools/android/appstats.py:86: Missing check_return=True.
+WARNING:tools/android/appstats.py:129: Missing check_return=True.
+WARNING:tools/android/appstats.py:266: Missing check_return=True.
+WARNING:tools/android/loading/device_setup.py:94: Missing check_return=True.
+WARNING:tools/resource_prefetch_predictor/prefetch_benchmark.py:92: Missing check_return=True.
« no previous file with comments | « cataput_issues.txt ('k') | lint_shell_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698