Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cataput_issues.txt

Issue 2693893009: [NOT FOR COMMINT] Linter for RunShellCommand calls (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromium_issues.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cataput_issues.txt
diff --git a/cataput_issues.txt b/cataput_issues.txt
new file mode 100644
index 0000000000000000000000000000000000000000..7ce70acb25976c054fcdf90cd66ce91616c3ae69
--- /dev/null
+++ b/cataput_issues.txt
@@ -0,0 +1,155 @@
+WARNING:telemetry/telemetry/core/android_action_runner.py:71: Missing check_return=True.
+WARNING:telemetry/telemetry/core/android_action_runner.py:79: Missing check_return=True.
+WARNING:telemetry/telemetry/core/android_action_runner.py:88: Missing check_return=True.
+WARNING:telemetry/telemetry/core/android_action_runner.py:102: Missing check_return=True.
+WARNING:telemetry/telemetry/core/android_action_runner.py:109: Avoid passing command as a string.
+WARNING:telemetry/telemetry/core/android_action_runner.py:109: Missing check_return=True.
+WARNING:telemetry/telemetry/core/android_action_runner.py:118: Missing check_return=True.
+WARNING:telemetry/telemetry/core/android_action_runner.py:156: Avoid passing command as a string.
+WARNING:telemetry/telemetry/core/android_action_runner.py:156: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/backends/chrome/android_browser_backend.py:76: Avoid passing command as a string.
+WARNING:telemetry/telemetry/internal/backends/chrome/android_browser_backend.py:76: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:274: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:339: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:376: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:593: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:610: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:796: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:387: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:459: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:472: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:601: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:680: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py:64: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py:49: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py:51: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/v8_profiler.py:49: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:58: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:79: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:81: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:88: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler_helper.py:31: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/netlog_profiler.py:47: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/tcpdump_profiler.py:30: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/tcpdump_profiler.py:50: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/perf_profiler.py:94: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/perf_profiler.py:96: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py:68: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py:29: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py:32: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py:34: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py:41: Missing check_return=True.
+WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py:58: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:67: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:56: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:177: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:227: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:236: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:314: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:240: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:238: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:272: Avoid passing command as a string.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:272: Missing check_return=True.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:280: Avoid passing command as a string.
+WARNING:systrace/systrace/tracing_agents/atrace_agent.py:280: Missing check_return=True.
+WARNING:systrace/profile_chrome/perf_tracing_agent.py:122: Missing check_return=True.
+WARNING:systrace/profile_chrome/ddms_tracing_agent.py:30: Avoid passing command as a string.
+WARNING:systrace/profile_chrome/ddms_tracing_agent.py:30: Missing check_return=True.
+WARNING:systrace/profile_chrome/ddms_tracing_agent.py:43: Missing check_return=True.
+WARNING:systrace/profile_chrome/ddms_tracing_agent.py:48: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:90: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:95: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:105: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:110: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:123: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:127: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:147: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:150: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:153: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:190: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:194: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:200: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:204: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:209: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_devicetest.py:214: Missing check_return=True.
+WARNING:devil/devil/android/settings.py:143: Missing check_return=True.
+WARNING:devil/devil/android/settings.py:183: Missing check_return=True.
+WARNING:devil/devil/android/settings.py:273: Missing check_return=True.
+WARNING:devil/devil/android/settings.py:167: Missing check_return=True.
+WARNING:devil/devil/android/settings.py:174: Missing check_return=True.
+WARNING:devil/devil/android/settings.py:161: Missing check_return=True.
+WARNING:devil/devil/android/install_commands.py:45: Missing check_return=True.
+WARNING:devil/devil/android/device_utils.py:504: Consider switching check_return=should_check_return to True.
+WARNING:devil/devil/android/device_utils.py:951: Missing check_return=True.
+WARNING:devil/devil/android/device_utils.py:2564: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils.py:2564: Missing check_return=True.
+WARNING:devil/devil/android/device_utils.py:2495: Missing check_return=True.
+WARNING:devil/devil/android/device_utils.py:600: Consider switching check_return=False to True.
+WARNING:devil/devil/android/device_utils_test.py:852: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:856: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:860: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:860: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:865: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:865: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:870: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:870: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:874: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:874: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:878: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:878: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:883: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:883: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:918: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:918: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:925: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:940: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:1049: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1058: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1068: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1078: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1337: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1357: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1366: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1612: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1634: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1642: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1650: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1658: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1667: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:1829: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:2612: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:894: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:909: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:949: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:955: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:961: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:967: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:973: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:979: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:986: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:1007: Consider switching check_return=False to True.
+WARNING:devil/devil/android/device_utils_test.py:1346: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:2726: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:2726: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:2734: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:2734: Missing check_return=True.
+WARNING:devil/devil/android/device_utils_test.py:2742: Avoid passing command as a string.
+WARNING:devil/devil/android/device_utils_test.py:2742: Missing check_return=True.
+WARNING:devil/devil/android/flag_changer.py:196: Missing check_return=True.
+WARNING:devil/devil/android/tools/provision_devices.py:228: Missing check_return=True.
+WARNING:devil/devil/android/tools/provision_devices.py:464: Avoid passing command as a string.
+WARNING:devil/devil/android/tools/provision_devices.py:208: Avoid passing command as a string.
+WARNING:devil/devil/android/tools/provision_devices.py:230: Missing check_return=True.
+WARNING:devil/devil/android/tools/provision_devices.py:437: Missing check_return=True.
+WARNING:devil/devil/android/tools/video_recorder.py:110: Missing check_return=True.
+WARNING:devil/devil/android/tools/device_monitor.py:119: Avoid passing command as a string.
+WARNING:devil/devil/android/perf/thermal_throttle.py:127: Avoid passing command as a string.
+WARNING:devil/devil/android/perf/thermal_throttle.py:127: Missing check_return=True.
+WARNING:devil/devil/android/perf/cache_control.py:14: Avoid passing command as a string.
+WARNING:devil/devil/android/perf/cache_control.py:14: Missing check_return=True.
+WARNING:devil/devil/android/perf/surface_stats_collector.py:107: Avoid passing command as a string.
+WARNING:devil/devil/android/perf/surface_stats_collector.py:107: Missing check_return=True.
+WARNING:devil/devil/android/perf/surface_stats_collector.py:112: Avoid passing command as a string.
+WARNING:devil/devil/android/perf/surface_stats_collector.py:112: Missing check_return=True.
+WARNING:devil/devil/android/perf/surface_stats_collector.py:158: Avoid passing command as a string.
+WARNING:devil/devil/android/perf/surface_stats_collector.py:158: Missing check_return=True.
« no previous file with comments | « no previous file | chromium_issues.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698