Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chromium_issues.txt

Issue 2693893009: [NOT FOR COMMINT] Linter for RunShellCommand calls (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cataput_issues.txt ('k') | lint_shell_commands.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 WARNING:build/android/provision_devices.py:413: Avoid passing command as a strin g.
2 WARNING:build/android/provision_devices.py:421: Missing check_return=True.
3 WARNING:build/android/provision_devices.py:191: Avoid passing command as a strin g.
4 WARNING:build/android/provision_devices.py:423: Missing check_return=True.
5 WARNING:build/android/provision_devices.py:390: Missing check_return=True.
6 WARNING:build/android/enable_asserts.py:45: Avoid passing command as a string.
7 WARNING:build/android/enable_asserts.py:45: Missing check_return=True.
8 WARNING:build/android/enable_asserts.py:46: Avoid passing command as a string.
9 WARNING:build/android/enable_asserts.py:46: Missing check_return=True.
10 WARNING:build/android/gyp/push_libraries.py:43: Missing check_return=True.
11 WARNING:build/android/gyp/util/build_device.py:36: Missing check_return=True.
12 WARNING:build/android/pylib/device_settings.py:98: Missing check_return=True.
13 WARNING:build/android/pylib/content_settings.py:35: Missing check_return=True.
14 WARNING:build/android/pylib/content_settings.py:75: Missing check_return=True.
15 WARNING:build/android/pylib/content_settings.py:59: Missing check_return=True.
16 WARNING:build/android/pylib/content_settings.py:66: Missing check_return=True.
17 WARNING:build/android/pylib/content_settings.py:53: Missing check_return=True.
18 WARNING:build/android/pylib/valgrind_tools.py:23: Missing check_return=True.
19 WARNING:build/android/pylib/valgrind_tools.py:104: Missing check_return=True.
20 WARNING:build/android/pylib/valgrind_tools.py:106: Missing check_return=True.
21 WARNING:build/android/pylib/valgrind_tools.py:117: Avoid passing command as a st ring.
22 WARNING:build/android/pylib/valgrind_tools.py:117: Missing check_return=True.
23 WARNING:build/android/pylib/valgrind_tools.py:118: Avoid passing command as a st ring.
24 WARNING:build/android/pylib/valgrind_tools.py:118: Missing check_return=True.
25 WARNING:build/android/pylib/valgrind_tools.py:120: Missing check_return=True.
26 WARNING:build/android/pylib/valgrind_tools.py:127: Missing check_return=True.
27 WARNING:build/android/pylib/local/device/local_device_monkey_test_run.py:117: Mi ssing check_return=True.
28 WARNING:build/android/pylib/local/device/local_device_gtest_run.py:237: Consider switching check_return=False to True.
29 WARNING:build/android/pylib/local/device/local_device_instrumentation_test_run.p y:353: Missing check_return=True.
30 WARNING:skia/tools/clusterfuzz-data/fuzzers/mbarbella_webgl/shader_generator.py: Parse error, skipping.
31 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 54: Avoid passing command as a string.
32 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 54: Missing check_return=True.
33 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 79: Missing check_return=True.
34 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 82: Missing check_return=True.
35 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 105: Missing check_return=True.
36 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 109: Missing check_return=True.
37 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 155: Avoid passing command as a string.
38 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 155: Missing check_return=True.
39 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 267: Missing check_return=True.
40 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 268: Missing check_return=True.
41 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 438: Missing check_return=True.
42 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 456: Avoid passing command as a string.
43 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 456: Missing check_return=True.
44 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 462: Avoid passing command as a string.
45 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 462: Missing check_return=True.
46 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 86: Avoid passing command as a string.
47 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 86: Missing check_return=True.
48 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 458: Avoid passing command as a string.
49 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 458: Missing check_return=True.
50 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 459: Avoid passing command as a string.
51 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 459: Missing check_return=True.
52 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 464: Avoid passing command as a string.
53 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 464: Missing check_return=True.
54 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 465: Avoid passing command as a string.
55 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 465: Missing check_return=True.
56 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 342: Avoid passing command as a string.
57 WARNING:components/cronet/android/test/javaperftests/android_rndis_forwarder.py: 342: Missing check_return=True.
58 WARNING:components/cronet/android/test/javaperftests/run.py:142: Missing check_r eturn=True.
59 WARNING:components/cronet/android/test/javaperftests/run.py:240: Missing check_r eturn=True.
60 WARNING:v8/src/js/macros.py: Parse error, skipping.
61 WARNING:v8/tools/gen-inlining-tests.py: Parse error, skipping.
62 WARNING:v8/tools/run_perf.py:703: Missing check_return=True.
63 WARNING:v8/tools/run_perf.py:796: Missing check_return=True.
64 WARNING:tools/android/appstats.py:212: Missing check_return=True.
65 WARNING:tools/android/appstats.py:86: Missing check_return=True.
66 WARNING:tools/android/appstats.py:129: Missing check_return=True.
67 WARNING:tools/android/appstats.py:266: Missing check_return=True.
68 WARNING:tools/android/loading/device_setup.py:94: Missing check_return=True.
69 WARNING:tools/resource_prefetch_predictor/prefetch_benchmark.py:92: Missing chec k_return=True.
OLDNEW
« no previous file with comments | « cataput_issues.txt ('k') | lint_shell_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698