Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: cataput_issues.txt

Issue 2693893009: [NOT FOR COMMINT] Linter for RunShellCommand calls (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromium_issues.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 WARNING:telemetry/telemetry/core/android_action_runner.py:71: Missing check_retu rn=True.
2 WARNING:telemetry/telemetry/core/android_action_runner.py:79: Missing check_retu rn=True.
3 WARNING:telemetry/telemetry/core/android_action_runner.py:88: Missing check_retu rn=True.
4 WARNING:telemetry/telemetry/core/android_action_runner.py:102: Missing check_ret urn=True.
5 WARNING:telemetry/telemetry/core/android_action_runner.py:109: Avoid passing com mand as a string.
6 WARNING:telemetry/telemetry/core/android_action_runner.py:109: Missing check_ret urn=True.
7 WARNING:telemetry/telemetry/core/android_action_runner.py:118: Missing check_ret urn=True.
8 WARNING:telemetry/telemetry/core/android_action_runner.py:156: Avoid passing com mand as a string.
9 WARNING:telemetry/telemetry/core/android_action_runner.py:156: Missing check_ret urn=True.
10 WARNING:telemetry/telemetry/internal/backends/chrome/android_browser_backend.py: 76: Avoid passing command as a string.
11 WARNING:telemetry/telemetry/internal/backends/chrome/android_browser_backend.py: 76: Missing check_return=True.
12 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:274: M issing check_return=True.
13 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:339: M issing check_return=True.
14 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:376: M issing check_return=True.
15 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:593: M issing check_return=True.
16 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:610: M issing check_return=True.
17 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:796: M issing check_return=True.
18 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:387: M issing check_return=True.
19 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:459: M issing check_return=True.
20 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:472: M issing check_return=True.
21 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:601: M issing check_return=True.
22 WARNING:telemetry/telemetry/internal/platform/android_platform_backend.py:680: M issing check_return=True.
23 WARNING:telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py :64: Missing check_return=True.
24 WARNING:telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py :49: Missing check_return=True.
25 WARNING:telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py :51: Missing check_return=True.
26 WARNING:telemetry/telemetry/internal/platform/profiler/v8_profiler.py:49: Missin g check_return=True.
27 WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:58: Missing check_return=True.
28 WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:79: Missing check_return=True.
29 WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:81: Missing check_return=True.
30 WARNING:telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py:88: Missing check_return=True.
31 WARNING:telemetry/telemetry/internal/platform/profiler/android_prebuilt_profiler _helper.py:31: Missing check_return=True.
32 WARNING:telemetry/telemetry/internal/platform/profiler/netlog_profiler.py:47: Mi ssing check_return=True.
33 WARNING:telemetry/telemetry/internal/platform/profiler/tcpdump_profiler.py:30: M issing check_return=True.
34 WARNING:telemetry/telemetry/internal/platform/profiler/tcpdump_profiler.py:50: M issing check_return=True.
35 WARNING:telemetry/telemetry/internal/platform/profiler/perf_profiler.py:94: Miss ing check_return=True.
36 WARNING:telemetry/telemetry/internal/platform/profiler/perf_profiler.py:96: Miss ing check_return=True.
37 WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profile r.py:68: Missing check_return=True.
38 WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profile r.py:29: Missing check_return=True.
39 WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profile r.py:32: Missing check_return=True.
40 WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profile r.py:34: Missing check_return=True.
41 WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profile r.py:41: Missing check_return=True.
42 WARNING:telemetry/telemetry/internal/platform/profiler/android_traceview_profile r.py:58: Missing check_return=True.
43 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:67: Missing check_retur n=True.
44 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:56: Missing check_retur n=True.
45 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:177: Missing check_retu rn=True.
46 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:227: Missing check_retu rn=True.
47 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:236: Missing check_retu rn=True.
48 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:314: Missing check_retu rn=True.
49 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:240: Missing check_retu rn=True.
50 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:238: Missing check_retu rn=True.
51 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:272: Avoid passing comm and as a string.
52 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:272: Missing check_retu rn=True.
53 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:280: Avoid passing comm and as a string.
54 WARNING:systrace/systrace/tracing_agents/atrace_agent.py:280: Missing check_retu rn=True.
55 WARNING:systrace/profile_chrome/perf_tracing_agent.py:122: Missing check_return= True.
56 WARNING:systrace/profile_chrome/ddms_tracing_agent.py:30: Avoid passing command as a string.
57 WARNING:systrace/profile_chrome/ddms_tracing_agent.py:30: Missing check_return=T rue.
58 WARNING:systrace/profile_chrome/ddms_tracing_agent.py:43: Missing check_return=T rue.
59 WARNING:systrace/profile_chrome/ddms_tracing_agent.py:48: Missing check_return=T rue.
60 WARNING:devil/devil/android/device_utils_devicetest.py:90: Missing check_return= True.
61 WARNING:devil/devil/android/device_utils_devicetest.py:95: Missing check_return= True.
62 WARNING:devil/devil/android/device_utils_devicetest.py:105: Missing check_return =True.
63 WARNING:devil/devil/android/device_utils_devicetest.py:110: Missing check_return =True.
64 WARNING:devil/devil/android/device_utils_devicetest.py:123: Missing check_return =True.
65 WARNING:devil/devil/android/device_utils_devicetest.py:127: Missing check_return =True.
66 WARNING:devil/devil/android/device_utils_devicetest.py:147: Missing check_return =True.
67 WARNING:devil/devil/android/device_utils_devicetest.py:150: Missing check_return =True.
68 WARNING:devil/devil/android/device_utils_devicetest.py:153: Missing check_return =True.
69 WARNING:devil/devil/android/device_utils_devicetest.py:190: Missing check_return =True.
70 WARNING:devil/devil/android/device_utils_devicetest.py:194: Missing check_return =True.
71 WARNING:devil/devil/android/device_utils_devicetest.py:200: Missing check_return =True.
72 WARNING:devil/devil/android/device_utils_devicetest.py:204: Missing check_return =True.
73 WARNING:devil/devil/android/device_utils_devicetest.py:209: Missing check_return =True.
74 WARNING:devil/devil/android/device_utils_devicetest.py:214: Missing check_return =True.
75 WARNING:devil/devil/android/settings.py:143: Missing check_return=True.
76 WARNING:devil/devil/android/settings.py:183: Missing check_return=True.
77 WARNING:devil/devil/android/settings.py:273: Missing check_return=True.
78 WARNING:devil/devil/android/settings.py:167: Missing check_return=True.
79 WARNING:devil/devil/android/settings.py:174: Missing check_return=True.
80 WARNING:devil/devil/android/settings.py:161: Missing check_return=True.
81 WARNING:devil/devil/android/install_commands.py:45: Missing check_return=True.
82 WARNING:devil/devil/android/device_utils.py:504: Consider switching check_return =should_check_return to True.
83 WARNING:devil/devil/android/device_utils.py:951: Missing check_return=True.
84 WARNING:devil/devil/android/device_utils.py:2564: Avoid passing command as a str ing.
85 WARNING:devil/devil/android/device_utils.py:2564: Missing check_return=True.
86 WARNING:devil/devil/android/device_utils.py:2495: Missing check_return=True.
87 WARNING:devil/devil/android/device_utils.py:600: Consider switching check_return =False to True.
88 WARNING:devil/devil/android/device_utils_test.py:852: Missing check_return=True.
89 WARNING:devil/devil/android/device_utils_test.py:856: Missing check_return=True.
90 WARNING:devil/devil/android/device_utils_test.py:860: Avoid passing command as a string.
91 WARNING:devil/devil/android/device_utils_test.py:860: Missing check_return=True.
92 WARNING:devil/devil/android/device_utils_test.py:865: Avoid passing command as a string.
93 WARNING:devil/devil/android/device_utils_test.py:865: Missing check_return=True.
94 WARNING:devil/devil/android/device_utils_test.py:870: Avoid passing command as a string.
95 WARNING:devil/devil/android/device_utils_test.py:870: Missing check_return=True.
96 WARNING:devil/devil/android/device_utils_test.py:874: Avoid passing command as a string.
97 WARNING:devil/devil/android/device_utils_test.py:874: Missing check_return=True.
98 WARNING:devil/devil/android/device_utils_test.py:878: Avoid passing command as a string.
99 WARNING:devil/devil/android/device_utils_test.py:878: Missing check_return=True.
100 WARNING:devil/devil/android/device_utils_test.py:883: Avoid passing command as a string.
101 WARNING:devil/devil/android/device_utils_test.py:883: Missing check_return=True.
102 WARNING:devil/devil/android/device_utils_test.py:918: Avoid passing command as a string.
103 WARNING:devil/devil/android/device_utils_test.py:918: Missing check_return=True.
104 WARNING:devil/devil/android/device_utils_test.py:925: Missing check_return=True.
105 WARNING:devil/devil/android/device_utils_test.py:940: Missing check_return=True.
106 WARNING:devil/devil/android/device_utils_test.py:1049: Avoid passing command as a string.
107 WARNING:devil/devil/android/device_utils_test.py:1058: Avoid passing command as a string.
108 WARNING:devil/devil/android/device_utils_test.py:1068: Avoid passing command as a string.
109 WARNING:devil/devil/android/device_utils_test.py:1078: Avoid passing command as a string.
110 WARNING:devil/devil/android/device_utils_test.py:1337: Avoid passing command as a string.
111 WARNING:devil/devil/android/device_utils_test.py:1357: Avoid passing command as a string.
112 WARNING:devil/devil/android/device_utils_test.py:1366: Avoid passing command as a string.
113 WARNING:devil/devil/android/device_utils_test.py:1612: Avoid passing command as a string.
114 WARNING:devil/devil/android/device_utils_test.py:1634: Avoid passing command as a string.
115 WARNING:devil/devil/android/device_utils_test.py:1642: Avoid passing command as a string.
116 WARNING:devil/devil/android/device_utils_test.py:1650: Avoid passing command as a string.
117 WARNING:devil/devil/android/device_utils_test.py:1658: Avoid passing command as a string.
118 WARNING:devil/devil/android/device_utils_test.py:1667: Avoid passing command as a string.
119 WARNING:devil/devil/android/device_utils_test.py:1829: Avoid passing command as a string.
120 WARNING:devil/devil/android/device_utils_test.py:2612: Missing check_return=True .
121 WARNING:devil/devil/android/device_utils_test.py:894: Missing check_return=True.
122 WARNING:devil/devil/android/device_utils_test.py:909: Missing check_return=True.
123 WARNING:devil/devil/android/device_utils_test.py:949: Missing check_return=True.
124 WARNING:devil/devil/android/device_utils_test.py:955: Missing check_return=True.
125 WARNING:devil/devil/android/device_utils_test.py:961: Missing check_return=True.
126 WARNING:devil/devil/android/device_utils_test.py:967: Missing check_return=True.
127 WARNING:devil/devil/android/device_utils_test.py:973: Missing check_return=True.
128 WARNING:devil/devil/android/device_utils_test.py:979: Missing check_return=True.
129 WARNING:devil/devil/android/device_utils_test.py:986: Missing check_return=True.
130 WARNING:devil/devil/android/device_utils_test.py:1007: Consider switching check_ return=False to True.
131 WARNING:devil/devil/android/device_utils_test.py:1346: Avoid passing command as a string.
132 WARNING:devil/devil/android/device_utils_test.py:2726: Avoid passing command as a string.
133 WARNING:devil/devil/android/device_utils_test.py:2726: Missing check_return=True .
134 WARNING:devil/devil/android/device_utils_test.py:2734: Avoid passing command as a string.
135 WARNING:devil/devil/android/device_utils_test.py:2734: Missing check_return=True .
136 WARNING:devil/devil/android/device_utils_test.py:2742: Avoid passing command as a string.
137 WARNING:devil/devil/android/device_utils_test.py:2742: Missing check_return=True .
138 WARNING:devil/devil/android/flag_changer.py:196: Missing check_return=True.
139 WARNING:devil/devil/android/tools/provision_devices.py:228: Missing check_return =True.
140 WARNING:devil/devil/android/tools/provision_devices.py:464: Avoid passing comman d as a string.
141 WARNING:devil/devil/android/tools/provision_devices.py:208: Avoid passing comman d as a string.
142 WARNING:devil/devil/android/tools/provision_devices.py:230: Missing check_return =True.
143 WARNING:devil/devil/android/tools/provision_devices.py:437: Missing check_return =True.
144 WARNING:devil/devil/android/tools/video_recorder.py:110: Missing check_return=Tr ue.
145 WARNING:devil/devil/android/tools/device_monitor.py:119: Avoid passing command a s a string.
146 WARNING:devil/devil/android/perf/thermal_throttle.py:127: Avoid passing command as a string.
147 WARNING:devil/devil/android/perf/thermal_throttle.py:127: Missing check_return=T rue.
148 WARNING:devil/devil/android/perf/cache_control.py:14: Avoid passing command as a string.
149 WARNING:devil/devil/android/perf/cache_control.py:14: Missing check_return=True.
150 WARNING:devil/devil/android/perf/surface_stats_collector.py:107: Avoid passing c ommand as a string.
151 WARNING:devil/devil/android/perf/surface_stats_collector.py:107: Missing check_r eturn=True.
152 WARNING:devil/devil/android/perf/surface_stats_collector.py:112: Avoid passing c ommand as a string.
153 WARNING:devil/devil/android/perf/surface_stats_collector.py:112: Missing check_r eturn=True.
154 WARNING:devil/devil/android/perf/surface_stats_collector.py:158: Avoid passing c ommand as a string.
155 WARNING:devil/devil/android/perf/surface_stats_collector.py:158: Missing check_r eturn=True.
OLDNEW
« no previous file with comments | « no previous file | chromium_issues.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698