Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2693863004: Fix race condition in gitdeps.py (Closed)

Created:
3 years, 10 months ago by veranika
Modified:
3 years, 10 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Fix race condition in gitdeps.py The loop to delete orphaned directories uses threading to delete directories in parallel. Threads were created from a lambda function, which closed a variable. The variable was redefined in a loop, which lead to a race condition. BUG= Review-Url: https://codereview.chromium.org/2693863004 Committed: https://github.com/google/syzygy/commit/56b2e0256d3a18f1fede244fdae53344a54f97be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M syzygy/build/gitdeps.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
veranika
3 years, 10 months ago (2017-02-14 19:55:08 UTC) #3
Sébastien Marchand
lgtm
3 years, 10 months ago (2017-02-14 21:25:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693863004/1
3 years, 10 months ago (2017-02-14 21:34:46 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 22:17:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/google/syzygy/commit/56b2e0256d3a18f1fede244fdae53344a54f97be

Powered by Google App Engine
This is Rietveld 408576698