Fix race condition in gitdeps.py

syzygy/build/gitdeps.py

 # Copyright 2014 Google Inc. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 511 matching lines @@
       # so that the new checkout can start immediately.
       _LOGGER.info('Erasing stale checkout directory: %s', repo.checkout_dir)
 
       # Any existing junctions to this repo must be removed otherwise the
       # rename may fail.
       for d in repo.remote_dirs:
         j = os.path.abspath(os.path.join(repo.output_dir, d))
         _RemoveOrphanedJunction(options, j)
 
       newpath = _RenameCheckout(repo.checkout_dir, options.dry_run)
-      body = lambda: _DeleteCheckout(newpath, options.dry_run)
-      thread = threading.Thread(target=body)
+      thread = threading.Thread(target=_DeleteCheckout,
+                                args=(newpath, options.dry_run))
       threads.append(thread)
       thread.start()
 
   # Create and update the checkout as necessary.
   if create_checkout:
     _CreateCheckout(repo.checkout_dir, repo, options.dry_run)
   else:
     _LOGGER.debug('Reusing checkout directory: %s', repo.checkout_dir)
   if update_checkout:
     _UpdateCheckout(repo.checkout_dir, repo, options.dry_run)
@@ skipping 351 matching lines @@
         io.write(j)
         io.write('\n')
 
   # Iterate all directories in the cache directory. Any that we didn't
   # specifically create or update should be cleaned up. Do this in parallel
   # so things are cleaned up as soon as possible.
   threads = []
   for path in glob.glob(os.path.join(options.cache_dir, '*')):
     if os.path.join(path, 'src') not in checkout_dirs:
       _LOGGER.debug('Erasing orphaned checkout directory: %s', path)
-      body = lambda: _DeleteCheckout(path, options.dry_run)
-      thread = threading.Thread(target=body)
+      thread = threading.Thread(target=_DeleteCheckout,
+                                args=(path, options.dry_run))
       threads.append(thread)
       thread.start()
   for thread in threads:
     thread.join()
 
   # Recursively process other dependencies.
   for repo in all_deps:
     if not repo.recurse:
       continue
     if not checkout_dirs[repo.checkout_dir] and not options.force:
       continue
     _RecurseRepository(options, repo)
 
   return
 
 
 if __name__ == '__main__':
   main()